fix: initial load threads edge case #1361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
There is currently a weird behaviour on the thread query-ing endpoint in the backend where if you call it with
{ limit: 0}
it skips the pagination entirely and returns all of the threads. While things aren't initialized yet, it is entirely possible that boththreads.length
andunseenThreadIds.length
are0
, hence the issue occurring (typically on the first ever load of the thread list).This PR takes care that this doesn't happen and the
limit
is never0
.Changelog