-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove emoji-mart & emoji-replacement from final builds #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnautov-anton
added a commit
that referenced
this pull request
Oct 31, 2023
BREAKING CHANGE: `emoji-mart` styles are now distributed separately (affects both styling versions)
arnautov-anton
force-pushed
the
fix/build-emoji-mart-separately
branch
from
October 31, 2023 16:03
c6bbd51
to
c073963
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
# [4.0.0-rc.1](v3.14.1...v4.0.0-rc.1) (2023-10-31) ### Bug Fixes * remove emoji-mart from final builds, distribute separately ([#246](#246)) ([9ad33d5](9ad33d5)) ### BREAKING CHANGES * `emoji-mart` styles are now distributed separately (affects both styling versions)
arnautov-anton
changed the title
fix: remove emoji-mart from final builds, distribute separately
fix: remove emoji-mart & emoji-replacement from final builds
Nov 8, 2023
commit 7e3e315 Author: Anton Arnautov <arnautov.anton@gmail.com> Date: Fri Nov 3 13:44:59 2023 +0100 Remove source map from the final build commit 5146741 Author: Anton Arnautov <arnautov.anton@gmail.com> Date: Wed Nov 1 14:37:32 2023 +0100 fix: remove str-chat class from emoji-replacement rules commit b76ea82 Author: Anton Arnautov <arnautov.anton@gmail.com> Date: Wed Nov 1 13:33:14 2023 +0100 Adjust the rules commit d5bc512 Author: Anton Arnautov <arnautov.anton@gmail.com> Date: Wed Nov 1 13:15:27 2023 +0100 Build emoji-replacement separately
arnautov-anton
force-pushed
the
fix/build-emoji-mart-separately
branch
from
November 27, 2023 11:12
8064159
to
40f55a4
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
# [4.0.0](v3.14.2...v4.0.0) (2023-11-27) ### Bug Fixes * remove emoji-mart & emoji-replacement from final builds ([#246](#246)) ([f2079c8](f2079c8)) ### BREAKING CHANGES * `emoji-mart` styles are now distributed separately (affects both styling versions) * `emoji-replacement` styles are now distributed separately (affects both styling versions) ### 🎯 Goal In `stream-chat-react@11.x.x` the `emoji-mart`-related components will become optional which means that bundling `emoji-mart` related styles to one output file is no longer feasible as some integrators might decide to not use these components at all making their final browser bundles contain unnecessary styling rules. `_emoji-replacement.scss` has been a part of the final CSS bundle even though some integrators might decide to not use this [Windows-only fallback](https://getstream.io/chat/docs/sdk/react/components/contexts/chat_context/#useimageflagemojisonwindow). Package `stream-chat-react` will be removing this flag and instead will make this set of rules optional for integrators to import explicitly if needed.
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
# [5.0.0-rc.1](v4.17.0...v5.0.0-rc.1) (2024-06-21) ### Bug Fixes * adjust MessageInput Autocomplete position above textarea with multiple rows ([#297](#297)) ([b3dd8de](b3dd8de)) * center message input elements ([615fff7](615fff7)) * remove emoji-mart from final builds, distribute separately ([#246](#246)) ([9ad33d5](9ad33d5)) * remove emoji-replacement from final builds, distribute separately ([#247](#247)) ([613f52d](613f52d)) * remove source maps ([8d923f2](8d923f2)) * remove str-chat class from emoji-replacement rules ([3bf8d68](3bf8d68)) ### Features * prepare for removal of legacy styles from stream-chat-react ([#296](#296)) ([e374e81](e374e81)) ### BREAKING CHANGES * emoji-replacement styles are now distributed separately (affects both styling versions) * `emoji-mart` styles are now distributed separately (affects both styling versions)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
# [5.0.0](v4.19.0...v5.0.0) (2024-09-17) ### Bug Fixes * center message input elements ([615fff7](615fff7)) * move ThreadListItem related styles to appropriate class ([82c2a71](82c2a71)) * remove emoji-mart from final builds, distribute separately ([#246](#246)) ([9ad33d5](9ad33d5)) * remove emoji-replacement from final builds, distribute separately ([#247](#247)) ([613f52d](613f52d)) * remove source maps ([8d923f2](8d923f2)) * remove str-chat class from emoji-replacement rules ([3bf8d68](3bf8d68)) * **ThreadListItem:** add text overflow for long user names ([#306](#306)) ([f9d7d54](f9d7d54)) ### Features * add styles to support dialog display in stream-chat-react ([#308](#308)) ([bc9e068](bc9e068)) * prepare for removal of legacy styles from stream-chat-react ([#296](#296)) ([e374e81](e374e81)) * remove str-chat__main-panel--hideOnThread rules ([#303](#303)) ([5d0bcb4](5d0bcb4)) * threads 2.0 styling ([#305](#305)) ([c138ed3](c138ed3)) ### BREAKING CHANGES * removal of str-chat__main-panel--hideOnThread rules * emoji-replacement styles are now distributed separately (affects both styling versions) * `emoji-mart` styles are now distributed separately (affects both styling versions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
emoji-mart
styles are now distributed separately (affects both styling versions)BREAKING CHANGE:
emoji-replacement
styles are now distributed separately (affects both styling versions)🎯 Goal
In
stream-chat-react@11.x.x
theemoji-mart
-related components will become optional which means that bundlingemoji-mart
related styles to one output file is no longer feasible as some integrators might decide to not use these components at all making their final browser bundles contain unnecessary styling rules._emoji-replacement.scss
has been a part of the final CSS bundle even though some integrators might decide to not use this Windows-only fallback. Packagestream-chat-react
will be removing this flag and instead will make this set of rules optional for integrators to import explicitly if needed.