Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AND-307] Expose UserId alias to avoid InternalStreamChatApi issues #5616

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

JcMinarro
Copy link
Member

🎯 Goal

The public Channel.currentUserUnreadCount() extension function is using UserId alias as argument, what make this function unavailable to anyone that is not opt-in for @InternalStreamChatApi.
Exposing UserId alias avoid @InternalStreamChatApi issues

🎉 GIF

@JcMinarro JcMinarro requested a review from a team as a code owner February 5, 2025 12:09
@JcMinarro JcMinarro changed the title Expose UserId alias to avoid InternalStreamChatApi issues [AND-307] Expose UserId alias to avoid InternalStreamChatApi issues Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.17 MB 3.17 MB 0.00 MB 🟢
stream-chat-android-offline 3.38 MB 3.38 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.86 MB 7.86 MB 0.00 MB 🟢
stream-chat-android-compose 8.75 MB 8.75 MB 0.00 MB 🟢

Copy link

sonarqubecloud bot commented Feb 5, 2025

@aleksandar-apostolov aleksandar-apostolov merged commit 114b1ba into develop Feb 5, 2025
12 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the exposer-user-id-alias branch February 5, 2025 12:34
Copy link

@irsyad-dev irsyad-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants