Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add html coverage reporting #25

Merged
merged 8 commits into from
Apr 8, 2023
Merged

Conversation

cameron-jobber
Copy link
Contributor

Adds HTML coverage reports to the reports generated by this tool.

Copy link
Contributor

@jcw- jcw- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow! this is great - I think this is reasonable, just needs:

  • a way to specify which reports are generated, probably an array of report types would work well?
  • I think you'll need to specify both the input file AND the output directory in the reporting method

src/mergeCoverage.js Outdated Show resolved Hide resolved
src/mergeCoverage.js Outdated Show resolved Hide resolved
src/mergeCoverage.js Outdated Show resolved Hide resolved
src/config.js Outdated Show resolved Hide resolved
@cameron-jobber cameron-jobber force-pushed the add-html-coverage-reporting branch from 6099e3e to 7e538ae Compare March 29, 2023 22:59
Copy link
Contributor Author

@cameron-jobber cameron-jobber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcw- I've done one pass of changes per your comments.

a way to specify which reports are generated, probably an array of report types would work well?

I haven't done this yet. Do you mean something like input arguments/options? or config options? or both? or something else?

src/mergeCoverage.js Outdated Show resolved Hide resolved
src/config.js Outdated Show resolved Hide resolved
src/mergeCoverage.js Outdated Show resolved Hide resolved
src/mergeCoverage.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jcw- jcw- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good - just one more requested change (a config option)!

src/mergeCoverage.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jcw- jcw- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do some testing on this soon, also one more thought...

src/mergeCoverage.js Outdated Show resolved Hide resolved
@cameron-jobber
Copy link
Contributor Author

Will do some testing on this soon, also one more thought...

@jcw- If you wanted to see this change in action, I've enabled it on this PR. You can see the coverage report (you were right!) in the 'Artifacts' tab here.

@cameron-jobber cameron-jobber requested a review from jcw- April 3, 2023 13:55
@jcw- jcw- changed the title add html coverage reporting feat: Add html coverage reporting Apr 8, 2023
@jcw- jcw- merged commit 54e9fb9 into main Apr 8, 2023
@jcw- jcw- deleted the add-html-coverage-reporting branch April 8, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants