-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add html coverage reporting #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow! this is great - I think this is reasonable, just needs:
- a way to specify which reports are generated, probably an array of report types would work well?
- I think you'll need to specify both the input file AND the output directory in the reporting method
6099e3e
to
7e538ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcw- I've done one pass of changes per your comments.
a way to specify which reports are generated, probably an array of report types would work well?
I haven't done this yet. Do you mean something like input arguments/options? or config options? or both? or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good - just one more requested change (a config option)!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do some testing on this soon, also one more thought...
Adds HTML coverage reports to the reports generated by this tool.