Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in test of uuid5 service #283

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Fix error in test of uuid5 service #283

merged 2 commits into from
Jan 7, 2020

Conversation

thierrydallacroce
Copy link
Contributor

@thierrydallacroce thierrydallacroce commented Jan 7, 2020

  1. Address the 2 errors below, returned by PHPUnit on our Uuid5 service.
  2. Increase test coverage to include Uuid5's isValid().
1) Drupal\dkan_data\Tests\Unit\Uuid5Test::testGenerate with data set "string" ('foo', 'bar', 'fd088d96-7c6b-5adf-8581-cbb18a5dad67')
Non-static method Drupal\dkan_data\Service\Uuid5::generate() should not be called statically

/Users/thierry.dallacroce/Code/pqdc/docroot/profiles/contrib/dkan2/modules/custom/dkan_data/tests/src/Unit/Service/Uuid5Test.php:33

2) Drupal\dkan_data\Tests\Unit\Uuid5Test::testGenerate with data set "non-string" ('foo', stdClass Object (...), 'e9de513e-b4d7-5b05-902b-f90ee7a5db52')
Non-static method Drupal\dkan_data\Service\Uuid5::generate() should not be called statically

/Users/thierry.dallacroce/Code/pqdc/docroot/profiles/contrib/dkan2/modules/custom/dkan_data/tests/src/Unit/Service/Uuid5Test.php:33

ERRORS!
Tests: 2, Assertions: 0, Errors: 2.

@fmizzell fmizzell merged commit 260db97 into master Jan 7, 2020
@thierrydallacroce thierrydallacroce deleted the fix-uuid5-test-error branch January 8, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants