-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post import status message #4397
Open
kaise-lafrai
wants to merge
6
commits into
2.x
Choose a base branch
from
Post-Import-Status-Message
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeder
requested changes
Jan 31, 2025
modules/datastore/tests/src/Unit/Service/PostImportResultTest.php
Outdated
Show resolved
Hide resolved
…improved handing of post import when reimporting existing datasets, improved tests
…ializing post import result object
…time when instantiatiating PostImportResult, improved PostImportResultTest
2d7fc7f
to
aff6791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [#4384 ]
Improvements to post import job status
QA Steps
Test 2.x branch to build an existing set of post import status rows in the dkan_post_import_job_status table.
ddev dkan-site-install
ddev dkan-sample-content
ddev drush uli
/admin/dkan/datastore/status
ddev drush dkan:datastore:import 3a187a87dc6cd47c48b6b4c4785224b7
ddev drush queue:run post_import
ddev drush dkan:datastore:reimport cedcd327-4e5d-43f9-8eb1-c11850fa7c55
ddev drush queue:run post_import
/admin/dkan/datastore/status
Test Post-Import-Status-Message to confirm a reimport and post import update the Datastore Import Status dashboard
ddev drush updatedb
ddev drush uli
/admin/dkan/datastore/status
ddev drush dkan:datastore:reimport cedcd327-4e5d-43f9-8eb1-c11850fa7c55
ddev drush queue:run post_import
/admin/dkan/datastore/status
Checklist before requesting review
If any of these are left unchecked, please provide an explanation