Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON Form Widget readme #4344

Merged
merged 23 commits into from
Dec 11, 2024
Merged

Add JSON Form Widget readme #4344

merged 23 commits into from
Dec 11, 2024

Conversation

rovcase
Copy link
Contributor

@rovcase rovcase commented Nov 20, 2024

Describe your changes

This adds a readme file to the JSON Form Widget module and updates related documentation accordingly.

QA Steps

  • The documentation is accurate.
  • Links within direct correctly.
  • Images within the documentation display correctly and include correct alt text.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added documentation

@rovcase rovcase marked this pull request as ready for review November 26, 2024 15:19
schema/collections/dataset.json Outdated Show resolved Hide resolved
modules/json_form_widget/README.md Outdated Show resolved Hide resolved
modules/json_form_widget/README.md Outdated Show resolved Hide resolved
modules/json_form_widget/README.md Outdated Show resolved Hide resolved
modules/json_form_widget/README.md Outdated Show resolved Hide resolved
@dafeder dafeder self-requested a review December 3, 2024 22:13
Copy link
Member

@dafeder dafeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions. Also wonder if we should more explicitly state that we have as a goal to make this module work independently of DKAN.

modules/json_form_widget/README.md Show resolved Hide resolved
modules/json_form_widget/README.md Show resolved Hide resolved
@rovcase
Copy link
Contributor Author

rovcase commented Dec 5, 2024

Ty both! We'll chat a bit about where to add the diagrams and if/how to add the decoupling goal on Fridays huddle. Then one more review after and this should be good.

modules/json_form_widget/README.md Outdated Show resolved Hide resolved
schema/collections/dataset.json Outdated Show resolved Hide resolved
modules/json_form_widget/README.md Show resolved Hide resolved
modules/json_form_widget/README.md Show resolved Hide resolved
@janette janette force-pushed the json-widget-readme branch 2 times, most recently from 45c932c to 492fb18 Compare December 6, 2024 22:44
@janette janette force-pushed the json-widget-readme branch from 492fb18 to 84a34fa Compare December 6, 2024 22:45
@rovcase rovcase requested a review from janette December 10, 2024 17:47
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
@rovcase rovcase requested a review from dafeder December 11, 2024 19:35
@dafeder dafeder merged commit 31f5342 into 2.x Dec 11, 2024
11 checks passed
@dafeder dafeder deleted the json-widget-readme branch December 11, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants