Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set form title based on data node type #4323

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Set form title based on data node type #4323

merged 1 commit into from
Oct 30, 2024

Conversation

janette
Copy link
Member

@janette janette commented Oct 23, 2024

Describe your changes

Change the form title when creating/editing data nodes.

QA Steps

  • Go to /node/add/data
  • Confirm the title is Create dataset
  • Go to /node/add/data?schema=data-dictionary
  • Confirm the title is Create data-dictionary

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@rovcase
Copy link
Contributor

rovcase commented Oct 30, 2024

  1. Confirm the data title
    image
  2. Confirm the data dictionary title
    image

Looks good to me!

@rovcase rovcase self-requested a review October 30, 2024 18:00
Copy link
Contributor

@rovcase rovcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests are passing in CI! Thanks!

@rovcase rovcase merged commit 5970437 into 2.x Oct 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants