Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-81: Enhancements on the onboarding flow #84

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Issue-81: Enhancements on the onboarding flow #84

merged 7 commits into from
Nov 20, 2024

Conversation

alexrodrigues
Copy link
Collaborator

@alexrodrigues alexrodrigues commented Nov 14, 2024 •
edited
Loading

There were some minor adjustments to the onboarding flow and the success screen. This PR includes all these changes.

Android (Small Phone):

android_small_3
android_small_success
android_small_4
android_small_1
android_small_2

iPad Success:

Simulator Screenshot - iPad (10th generation) - 2024-11-14 at 12 25 34

iPhone Success:

Simulator Screenshot - iPhone 16 - 2024-11-14 at 12 33 28

Happy Path:

success_web_happy_path.mp4

I will do this later:

will_do_this_later.mp4

Sad Path:

trying_to_break.mp4

New Constrained Scaffold:

new_constrained_scaffold_mobile.mp4
new_constrained_scaffold.mp4

closes issue #81

@alexrodrigues alexrodrigues linked an issue Nov 14, 2024 that may be closed by this pull request
Enhancements on the onboarding flow #81
Closed
4 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 862c5b9):

https://invoices-app-c2491--84-vdxb6rhp.web.app

(expires Tue, 26 Nov 2024 19:51:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1efa8e20144a509bbc65da83a78df541f9f717b9

@alexrodrigues alexrodrigues self-assigned this Nov 14, 2024
@alexrodrigues alexrodrigues added enhancement New feature or request design labels Nov 14, 2024
theolm
theolm reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@theolm theolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Pr.
I would suggest to also address the maxWidth of the main content.
I would create a custom scaffold for the screens to use, This way it will be easier to maintain.

lib/src/presentation/settings/success/onboarding_success_screen.dart Outdated Show resolved Hide resolved
@alexrodrigues alexrodrigues force-pushed the 81-enhancements-on-the-onboarding-flow branch from 0ae4332 to b632169 Compare November 18, 2024 19:36
theolm
theolm requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@theolm theolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component is missing some attributes and the pages still have different behaviour.

The new screen has a constrained size while the others have an infinity width.

lib/src/designsystem/constrained_scaffold.dart Outdated Show resolved Hide resolved
lib/src/presentation/settings/base_settings_page.dart Outdated Show resolved Hide resolved
lib/src/designsystem/constrained_scaffold.dart Outdated Show resolved Hide resolved
lib/src/presentation/settings/success/onboarding_success_screen.dart Outdated Show resolved Hide resolved
@alexrodrigues alexrodrigues force-pushed the 81-enhancements-on-the-onboarding-flow branch 2 times, most recently from ae78488 to 1895a1f Compare November 19, 2024 19:42
@alexrodrigues
creating the new constrained scaffold
862c5b9 
creating the new constrained scaffold

fixing the max width

Update constrained_scaffold.dart

missing default value

addressing ConstrainedScaffold's feedback
@alexrodrigues alexrodrigues force-pushed the 81-enhancements-on-the-onboarding-flow branch from 1895a1f to 862c5b9 Compare November 19, 2024 19:45
@alexrodrigues
Copy link
Collaborator Author

Thanks for your feedback @theolm!

@alexrodrigues alexrodrigues requested a review from theolm November 19, 2024 19:55
theolm
theolm approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@theolm theolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@theolm theolm merged commit e83d5f6 into main Nov 20, 2024
3 checks passed
@theolm theolm deleted the 81-enhancements-on-the-onboarding-flow branch November 20, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theolm theolm theolm approved these changes

@emilrb emilrb Awaiting requested review from emilrb

@pnalvarez pnalvarez Awaiting requested review from pnalvarez

Assignees

@alexrodrigues alexrodrigues

Labels
design enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancements on the onboarding flow
3 participants
@alexrodrigues @theolm @pnalvarez