Skip to content

Commit

Permalink
Bazel: Make build tool chain forward compatible
Browse files Browse the repository at this point in the history
Bazel 0.27 is going to flip incompatible Starlark flag:
--incompatible_string_join_requires_strings, see: [1] for
more details.

[1] bazelbuild/bazel#7802

Bug: Issue 10930
Change-Id: I058ba29a006e0af665830f3408e82cef4cbb1660
  • Loading branch information
davido committed May 30, 2019
1 parent 3ae5c32 commit 0c4d288
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tools/bzl/js.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ npm_binary = repository_rule(
def _run_npm_binary_str(ctx, tarball, args):
python_bin = ctx.which("python")
return " ".join([
python_bin,
ctx.path(ctx.attr._run_npm),
ctx.path(tarball),
str(python_bin),
str(ctx.path(ctx.attr._run_npm)),
str(ctx.path(tarball)),
] + args)

def _bower_archive(ctx):
Expand Down

0 comments on commit 0c4d288

Please sign in to comment.