Skip to content

Commit

Permalink
Bazel: Update rules_closure to make it forward compatible
Browse files Browse the repository at this point in the history
Gerrit cannot be built any more with upcoming Bazel 0.21 release.
That's because rules_closure depends on outdated protobuf version,
that uses some Bazel features that were discontinued in upcoming
Bazel 0.21 release.

Update rules_closure, so that we can upgrade Bazel and build gerrit
without passing this incompatible option:

  --incompatible_package_name_is_a_function=false

Bug: Issue 10112
Change-Id: I826471cce7c6a248838a466c458c228eb0a6b5d9
  • Loading branch information
davido authored and dpursehouse committed Jan 8, 2019
1 parent 09a18a8 commit 0812f52
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions gerrit_polymer.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive", "http_file"
def gerrit_polymer():
native.http_archive(
name = "io_bazel_rules_closure",
sha256 = "4dd84dd2bdd6c9f56cb5a475d504ea31d199c34309e202e9379501d01c3067e5",
strip_prefix = "rules_closure-3103a773820b59b76345f94c231cb213e0d404e2",
urls = ["https://github.com/bazelbuild/rules_closure/archive/3103a773820b59b76345f94c231cb213e0d404e2.tar.gz"],
sha256 = "d797d2410358bc8a4ceb1d26319b899acf4201f39cf2a99eb4b57212c01d76c7",
strip_prefix = "rules_closure-a34455e0c76769df13d25b67851252559fe7f83d",
urls = ["https://github.com/bazelbuild/rules_closure/archive/a34455e0c76769df13d25b67851252559fe7f83d.tar.gz"],
)

# File is specific to Polymer and copied from the Closure Github -- should be
Expand Down

0 comments on commit 0812f52

Please sign in to comment.