Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No icon on some 3DS games even with all keys present and valid. #208

Closed
felixsrg opened this issue Dec 18, 2019 · 4 comments
Closed

No icon on some 3DS games even with all keys present and valid. #208

felixsrg opened this issue Dec 18, 2019 · 4 comments
Assignees
Milestone

Comments

@felixsrg
Copy link

Yeah, pretty much what title says, I'm on Ubuntu 18.04 using Nautilus file browser, some icons work perfectly and some games just show no icon at all, like when the keys are missing or bad, but I have verified them all and the GUI shows the green check on them all.

It's also worth noting I've also tried wiping thumbnail data in cache and restarted both Nautilus and my Computer.

@felixsrg felixsrg changed the title [Bug] No icon on some 3DS games even with all keys present and valid. No icon on some 3DS games even with all keys present and valid. Dec 18, 2019
@cheatfreak47
Copy link

I can't confirm this exact same problem on Windows, but I can confirm it specifically for properly encrypted DLC packages, on the latest release version.

@GerbilSoft GerbilSoft self-assigned this Dec 19, 2019
@GerbilSoft GerbilSoft added the bug label Dec 19, 2019
@GerbilSoft GerbilSoft added this to the 1.5 milestone Dec 19, 2019
GerbilSoft added a commit that referenced this issue Dec 19, 2019
DLC CIAs are considered CFAs, so the NCCH doesn't have a ".code"
section. The first file is "icon", so check for that instead.

This fixes icon display for DLC CIAs.

Reported by CheatFreak in issue #208:
No icon on some 3DS games even with all keys present and valid.

TODO: Check if this fixes the original issue in #208.
@GerbilSoft
Copy link
Owner

For the DLC CIAs: The NCCHReader class was verifying encryption keys by checking that the first file in the ExeFS was named .code. This is correct for CXIs, but not for CFAs (which are used by DLCs); for CFAs, the first file is "icon".

@felixsrg Can you try compiling the latest code from the master branch and see if that fixes your issue? If not, please post rpcli output from the CIA files that aren't being thumbnailed correctly.

@felixsrg
Copy link
Author

I finally got the time to compile it, I'm sorry for the delay.

After compiling, all the icons started showing up correctly again, for encrypted and decrypted base, updates and DLCs.

@GerbilSoft
Copy link
Owner

GerbilSoft commented Dec 21, 2019

Thanks for confirming that it's fixed. Closing this bug.

If you encounter any other CIAs (or other 3DS files) that aren't thumbnailing properly, please file another bug and include the rpcli output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants