Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] Prevent objects from being returned several times in APIv2 by filtering on ManyToMany (refs #4448) #4449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Jan 13, 2025

Description

Related Issue

#4448

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@Chatewgne Chatewgne requested review from justinefricou and a team January 13, 2025 10:28
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (7bf9436) to head (6a29e0e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4449   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         268      268           
  Lines       21362    21362           
=======================================
  Hits        21035    21035           
  Misses        327      327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jan 13, 2025

Geotrek-admin    Run #10782

Run Properties:  status check passed Passed #10782  •  git commit ecee23fd89 ℹ️: Merge 6a29e0e7980cbd42739b4cc53c4f9dc5c1e835ac into 8af572ee2f5e69c268837036bca4...
Project Geotrek-admin
Branch Review refs/pull/4449/merge
Run status status check passed Passed #10782
Run duration 02m 03s
Commit git commit ecee23fd89 ℹ️: Merge 6a29e0e7980cbd42739b4cc53c4f9dc5c1e835ac into 8af572ee2f5e69c268837036bca4...
Committer Célia
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@submarcos submarcos linked an issue Jan 13, 2025 that may be closed by this pull request
@Chatewgne Chatewgne force-pushed the fix_api_v2_distinct branch from 13e6a23 to ad15791 Compare January 14, 2025 09:26
@Chatewgne Chatewgne force-pushed the fix_api_v2_distinct branch from ad15791 to 6a29e0e Compare January 14, 2025 09:27
@Chatewgne Chatewgne marked this pull request as ready for review January 14, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplication de données sur les relations ManyToMany dans l'API
2 participants