-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡ [PERF] Delay loading filter form in List Views #4432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chatewgne
force-pushed
the
perf_delay_filters
branch
2 times, most recently
from
December 27, 2024 13:45
bb18812
to
c22defd
Compare
Geotrek-admin Run #10741
Run Properties:
|
Project |
Geotrek-admin
|
Branch Review |
refs/pull/4432/merge
|
Run status |
Passed #10741
|
Run duration | 02m 00s |
Commit |
88b380c2c3 ℹ️: Merge 5d1d27aff00cb7a9daaface1e339d001cbdc1288 into 4dba2fb8f4dbf97c182d9c27228f...
|
Committer | Célia |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
22
|
View all changes introduced in this branch ↗︎ |
Chatewgne
force-pushed
the
perf_delay_filters
branch
from
December 27, 2024 14:12
c22defd
to
e367c9c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4432 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 268 268
Lines 21290 21362 +72
=======================================
+ Hits 20964 21035 +71
- Misses 326 327 +1 ☔ View full report in Codecov by Sentry. |
Chatewgne
force-pushed
the
perf_delay_filters
branch
from
December 27, 2024 14:39
e367c9c
to
5e8a737
Compare
Chatewgne
force-pushed
the
perf_delay_filters
branch
from
January 10, 2025 08:50
5e8a737
to
aef94d7
Compare
Bumps [charset-normalizer](https://github.com/Ousret/charset_normalizer) from 3.3.2 to 3.4.0. - [Release notes](https://github.com/Ousret/charset_normalizer/releases) - [Changelog](https://github.com/jawah/charset_normalizer/blob/master/CHANGELOG.md) - [Commits](jawah/charset_normalizer@3.3.2...3.4.0) --- updated-dependencies: - dependency-name: charset-normalizer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [persistent](https://github.com/zopefoundation/persistent) from 6.0 to 6.1. - [Changelog](https://github.com/zopefoundation/persistent/blob/master/CHANGES.rst) - [Commits](zopefoundation/persistent@6.0...6.1) --- updated-dependencies: - dependency-name: persistent dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [zodbpickle](https://github.com/zopefoundation/zodbpickle) from 4.0 to 4.1.1. - [Changelog](https://github.com/zopefoundation/zodbpickle/blob/master/CHANGES.rst) - [Commits](zopefoundation/zodbpickle@4.0...4.1.1) --- updated-dependencies: - dependency-name: zodbpickle dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [redis](https://github.com/redis/redis-py) from 5.2.0 to 5.2.1. - [Release notes](https://github.com/redis/redis-py/releases) - [Changelog](https://github.com/redis/redis-py/blob/master/CHANGES) - [Commits](redis/redis-py@v5.2.0...v5.2.1) --- updated-dependencies: - dependency-name: redis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.8.30 to 2024.12.14. - [Commits](certifi/python-certifi@2024.08.30...2024.12.14) --- updated-dependencies: - dependency-name: certifi dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [shapely](https://github.com/shapely/shapely) from 2.0.4 to 2.0.6. - [Release notes](https://github.com/shapely/shapely/releases) - [Changelog](https://github.com/shapely/shapely/blob/main/CHANGES.txt) - [Commits](shapely/shapely@2.0.4...2.0.6) --- updated-dependencies: - dependency-name: shapely dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [transaction](https://github.com/zopefoundation/transaction) from 3.1.0 to 5.0. - [Changelog](https://github.com/zopefoundation/transaction/blob/master/CHANGES.rst) - [Commits](zopefoundation/transaction@3.1.0...5.0) --- updated-dependencies: - dependency-name: transaction dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [cffi](https://github.com/python-cffi/cffi) from 1.16.0 to 1.17.1. - [Release notes](https://github.com/python-cffi/cffi/releases) - [Commits](python-cffi/cffi@v1.16.0...v1.17.1) --- updated-dependencies: - dependency-name: cffi dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.5. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.4...3.1.5) --- updated-dependencies: - dependency-name: jinja2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
- Move an object's related objects from the properties tab into their own tab - Move accessibility pictures into the attached files tab - Remove the display of the structure in the properties tab title
💄 [UI/UX] Restructure trek detail UI (refs #2967)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimize List View loading by delaying the loading of filtering options.
When a List View opens, the hidden filter form only includes BBOX to maintain map zoom filtering.
When clicking the "Filter" button, the full FilterSet (including BBOX and all other attributes) loads in the pop-up.
Related Issue
Issue : #2967 (comment)
Implements this MapEntity PR : makinacorpus/django-mapentity#312
Checklist