Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ [PERF] Delay loading filter form in List Views #4432

Merged
merged 12 commits into from
Jan 10, 2025
Merged

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Dec 27, 2024

Description

Optimize List View loading by delaying the loading of filtering options.

When a List View opens, the hidden filter form only includes BBOX to maintain map zoom filtering.

When clicking the "Filter" button, the full FilterSet (including BBOX and all other attributes) loads in the pop-up.

filters

Related Issue

Issue : #2967 (comment)

Implements this MapEntity PR : makinacorpus/django-mapentity#312

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@Chatewgne Chatewgne force-pushed the perf_delay_filters branch 2 times, most recently from bb18812 to c22defd Compare December 27, 2024 13:45
Copy link

cypress bot commented Dec 27, 2024

Geotrek-admin    Run #10741

Run Properties:  status check passed Passed #10741  •  git commit 88b380c2c3 ℹ️: Merge 5d1d27aff00cb7a9daaface1e339d001cbdc1288 into 4dba2fb8f4dbf97c182d9c27228f...
Project Geotrek-admin
Branch Review refs/pull/4432/merge
Run status status check passed Passed #10741
Run duration 02m 00s
Commit git commit 88b380c2c3 ℹ️: Merge 5d1d27aff00cb7a9daaface1e339d001cbdc1288 into 4dba2fb8f4dbf97c182d9c27228f...
Committer Célia
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (cf156cd) to head (5d1d27a).
Report is 31 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4432   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         268      268           
  Lines       21290    21362   +72     
=======================================
+ Hits        20964    21035   +71     
- Misses        326      327    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dependabot bot and others added 11 commits January 10, 2025 11:16
Bumps [charset-normalizer](https://github.com/Ousret/charset_normalizer) from 3.3.2 to 3.4.0.
- [Release notes](https://github.com/Ousret/charset_normalizer/releases)
- [Changelog](https://github.com/jawah/charset_normalizer/blob/master/CHANGELOG.md)
- [Commits](jawah/charset_normalizer@3.3.2...3.4.0)

---
updated-dependencies:
- dependency-name: charset-normalizer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [persistent](https://github.com/zopefoundation/persistent) from 6.0 to 6.1.
- [Changelog](https://github.com/zopefoundation/persistent/blob/master/CHANGES.rst)
- [Commits](zopefoundation/persistent@6.0...6.1)

---
updated-dependencies:
- dependency-name: persistent
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [zodbpickle](https://github.com/zopefoundation/zodbpickle) from 4.0 to 4.1.1.
- [Changelog](https://github.com/zopefoundation/zodbpickle/blob/master/CHANGES.rst)
- [Commits](zopefoundation/zodbpickle@4.0...4.1.1)

---
updated-dependencies:
- dependency-name: zodbpickle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [redis](https://github.com/redis/redis-py) from 5.2.0 to 5.2.1.
- [Release notes](https://github.com/redis/redis-py/releases)
- [Changelog](https://github.com/redis/redis-py/blob/master/CHANGES)
- [Commits](redis/redis-py@v5.2.0...v5.2.1)

---
updated-dependencies:
- dependency-name: redis
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.8.30 to 2024.12.14.
- [Commits](certifi/python-certifi@2024.08.30...2024.12.14)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [shapely](https://github.com/shapely/shapely) from 2.0.4 to 2.0.6.
- [Release notes](https://github.com/shapely/shapely/releases)
- [Changelog](https://github.com/shapely/shapely/blob/main/CHANGES.txt)
- [Commits](shapely/shapely@2.0.4...2.0.6)

---
updated-dependencies:
- dependency-name: shapely
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [transaction](https://github.com/zopefoundation/transaction) from 3.1.0 to 5.0.
- [Changelog](https://github.com/zopefoundation/transaction/blob/master/CHANGES.rst)
- [Commits](zopefoundation/transaction@3.1.0...5.0)

---
updated-dependencies:
- dependency-name: transaction
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [cffi](https://github.com/python-cffi/cffi) from 1.16.0 to 1.17.1.
- [Release notes](https://github.com/python-cffi/cffi/releases)
- [Commits](python-cffi/cffi@v1.16.0...v1.17.1)

---
updated-dependencies:
- dependency-name: cffi
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.1.4...3.1.5)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
- Move an object's related objects from the properties tab into their own tab
- Move accessibility pictures into the attached files tab
- Remove the display of the structure in the properties tab title
💄 [UI/UX] Restructure trek detail UI (refs #2967)
@Chatewgne Chatewgne merged commit c0de8ff into master Jan 10, 2025
22 checks passed
@Chatewgne Chatewgne deleted the perf_delay_filters branch January 10, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants