Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the module use line for esmf/8.4.1 on WCOSS2 #15

Conversation

BinLiu-NOAA
Copy link

DESCRIPTION OF CHANGES:

Remove the module use line for esmf/8.4.1 on WCOSS2. This change is needed for HAFSv1 code delivery.

TESTS CONDUCTED:

The esmf/8.4.1 on WCOSS2 is moved from dev to prod installation area, thus the module use line will be on longer needed. Test conducted on Dogwood.

@BinLiu-NOAA
Copy link
Author

@GeorgeGayno-NOAA, since removing this module use line is part of this release/1.10 work, I was thinking of merge this change to your release/1.10 branch. And it can then go back to develop together with your release/1.10 PR. Please feel free to let me know if this is not a preferred way. Thanks!

@GeorgeGayno-NOAA
Copy link
Owner

@GeorgeGayno-NOAA, since removing this module use line is part of this release/1.10 work, I was thinking of merge this change to your release/1.10 branch. And it can then go back to develop together with your release/1.10 PR. Please feel free to let me know if this is not a preferred way. Thanks!

That is an excellent idea.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit bfddd2d into GeorgeGayno-NOAA:release/1.10 Apr 13, 2023
@BinLiu-NOAA BinLiu-NOAA deleted the feature/wcoss2_esmf_prodloc branch July 3, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants