Autopoint #256

zhanggiene · 2022-12-25T07:50:46Z

added Autopoint class which is slimiar to point, but with functionality of calculating the gradient automatically. This PR is an updated version of this PR(Examples of using various automatic differentiation libraries. #243 ). More details can be found here

…/volesti into soc22_autodiffLibrary

…o autopoint

vissarion

Thanks! I am OK with merging in general. The only real issue is the difficulty to build and run the examples with autodiff. Could you please provide more detailed instructions in the README? Ideally autodiff should be fetched in the correct place by the cmake of volesti just like eigen. Is it possible to do this?

vissarion · 2023-01-03T10:00:29Z

include/generators/known_polytope_generators.h

@@ -30,7 +30,7 @@ Polytope generate_cube(const unsigned int& dim, const bool& Vpoly) {
        A.resize(2 * dim, dim);
        b.resize(2 * dim);
        for (unsigned int i = 0; i < dim; ++i) {
-            b(i) = 1.0;
+            b(i) = scale;


you assign scale which is of type const unsigned int to b(i) which is of type Polytope::NT, I think scale should be of that type too.

examples/Autopoint/README.md

examples/Autopoint/MultidimensionalGaussian_mixture_autopoint.cpp

examples/Autopoint/plot_hmc.py

papachristoumarios · 2023-01-03T19:29:15Z

examples/Autopoint/CMakeLists.txt

+  TARGET_LINK_LIBRARIES(Gaussian_mixture_autopoint ${LP_SOLVE} ${BLAS} autodiff::autodiff "-L${MKLROOT}/lib/intel64 -Wl,--no-as-needed -lmkl_intel_ilp64 -lmkl_gnu_thread -lmkl_core -lgomp -lpthread -lm -ldl")
+
+
+  add_executable (MultidimensionalGaussian_mixture_autopoint MultidimensionalGaussian_mixture_autopoint.cpp readData.cpp)


Try to eliminate whitespace

papachristoumarios · 2023-01-03T19:30:29Z

examples/Autopoint/README.md

+
+
+### Background information
+Autopoint is implemented using AUtodiff Library , after experiments of comparing various automatic differentiating libraries.Read [here](https://gist.github.com/zhanggiene/8471601fa25ba9db90303661b0e2237b) to find out more!


capitalization issue

papachristoumarios · 2023-01-03T19:31:47Z

examples/Autopoint/generate_gaussian_mixture_data.py

@@ -0,0 +1,15 @@
+import math


Should you have 1 file instead of two files for generating gaussian mixture data?
Also, can you please add flags to the generation script so that the user can define them from the command line?

the reason for the two separate files is because of the visualization part. I have taken out the visualization for generated data.

papachristoumarios · 2023-01-03T19:33:09Z

examples/Autopoint/readData.cpp

+    }
+    return result;
+
+}


Many of the files are missing newlines at the end of the file.

include/cartesian_geom/autopoint.h

papachristoumarios · 2023-01-03T19:36:53Z

include/ode_solvers/oracle_functors.hpp

@@ -392,4 +398,105 @@ struct HessianFunctor {

 };

+
+struct AutoDiffFunctor


Coding style should be fixed here

Are you talking about the code format or software best practice to write elegant and readable code?

both, but primarily the former.

zhanggiene · 2023-01-28T08:29:50Z

Autodiff library is automatically downloaded in a similar fashion as Boost and Eigen.

codecov · 2023-02-04T10:54:20Z

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.94%. Comparing base (e767f46) to head (aec4fb1).
Report is 9 commits behind head on develop.

❗ Current head aec4fb1 differs from pull request most recent head 0ebb07b. Consider uploading reports for the commit 0ebb07b to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #256      +/-   ##
===========================================
- Coverage    55.31%   53.94%   -1.38%     
===========================================
  Files          108      105       -3     
  Lines         6539     6166     -373     
  Branches      3026     2878     -148     
===========================================
- Hits          3617     3326     -291     
- Misses         948      964      +16     
+ Partials      1974     1876      -98

Files	Coverage Δ
include/generators/known_polytope_generators.h	`78.23% <100.00%> (ø)`
include/ode_solvers/oracle_functors.hpp	`28.57% <ø> (ø)`
include/diagnostics/print_diagnostics.hpp	`0.00% <0.00%> (ø)`

... and 27 files with indirect coverage changes

vissarion · 2023-02-14T08:34:05Z

test/CMakeLists.txt

@@ -26,6 +26,7 @@ endif()

 option(DISABLE_NLP_ORACLES "Disable non-linear oracles (used in collocation)" ON)
 option(BUILTIN_EIGEN "Use eigen from ../external" OFF)
+option(BUILTIN_AUTODIFF "Use eigen from ../external" ON)


there is a typo here

vissarion · 2023-02-14T08:39:40Z

include/ode_solvers/oracle_functors.hpp

+    typename NT>
+struct FunctionFunctor_internal
+{
+  typedef autopoint<NT> Autopoint;


you can go with using instead of typedef

examples/Autopoint/CMakeLists.txt

include/cartesian_geom/autopoint.h

examples/autopoint/MultidimensionalGaussian_mixture_autopoint.cpp

vfisikop · 2024-03-06T08:16:48Z

Since this is ready to merge as a feature, I will merge it now and fix possible issues in a future PR.

zhanggiene added 10 commits September 10, 2022 17:16

add 4 experiments

4fb3134

Merge branch 'soc22_autodiffLibrary' of https://github.com/zhanggiene…

07c35fe

…/volesti into soc22_autodiffLibrary

add pictures

879b22c

Autopoint initial

eb822b6

fix readme

684239a

take out object file

3a860c8

take out bank note

f5d8e66

Merge branch 'GeomScale:develop' into autopoint

839c53b

fix small bug

d35bdcf

Merge branch 'autopoint' of https://github.com/zhanggiene/volesti int…

c1a2696

…o autopoint

zhanggiene mentioned this pull request Dec 25, 2022

Examples of using various automatic differentiation libraries. #243

Closed

clean up

e95341c

vissarion requested review from papachristoumarios and vissarion January 3, 2023 09:55

vissarion requested changes Jan 3, 2023

View reviewed changes

papachristoumarios reviewed Jan 3, 2023

View reviewed changes

examples/Autopoint/plot_hmc.py Outdated Show resolved Hide resolved

papachristoumarios reviewed Jan 3, 2023

View reviewed changes

include/cartesian_geom/autopoint.h Show resolved Hide resolved

papachristoumarios reviewed Jan 3, 2023

View reviewed changes

add autodiff cmake scipts, improve python script

04961b7

vissarion added enhancement GSoC22 labels Feb 3, 2023

zhanggiene added 3 commits February 3, 2023 21:46

add cmake

6e7b053

fix readme

eabee62

change cmake file

d3ba3d0

vissarion approved these changes Feb 14, 2023

View reviewed changes

zhanggiene added 2 commits February 17, 2023 13:31

Merge branch 'GeomScale:develop' into autopoint

388efe8

fix style

cefe86c

papachristoumarios reviewed Feb 21, 2023

View reviewed changes

examples/autopoint/MultidimensionalGaussian_mixture_autopoint.cpp Show resolved Hide resolved

zhanggiene and others added 3 commits March 4, 2023 10:58

add manual learning rate

86d3fec

add autodiff into R makevars

aec4fb1

Merge branch 'develop' into autopoint

0ebb07b

vfisikop merged commit b2b5c06 into GeomScale:develop Mar 6, 2024
3 of 27 checks passed

vfisikop mentioned this pull request Mar 6, 2024

Enable c++17 support in tests and fix saxpy calls #292

Merged

TolisChal pushed a commit that referenced this pull request Jul 7, 2024

Autopoint (#256)

3e6393b

TolisChal pushed a commit that referenced this pull request Jul 7, 2024

Autopoint (#256)

ef0aaf5

TolisChal pushed a commit to TolisChal/volume_approximation that referenced this pull request Jul 7, 2024

Autopoint (GeomScale#256)

3ebe941

TolisChal pushed a commit to TolisChal/volume_approximation that referenced this pull request Jul 7, 2024

Autopoint (GeomScale#256)

2efa7d4

TolisChal pushed a commit to TolisChal/volume_approximation that referenced this pull request Jul 8, 2024

Autopoint (GeomScale#256)

5f9ad79

TolisChal pushed a commit to TolisChal/volume_approximation that referenced this pull request Jul 8, 2024

Autopoint (GeomScale#256)

e51d9ac

TolisChal pushed a commit to TolisChal/volume_approximation that referenced this pull request Jul 8, 2024

Autopoint (GeomScale#256)

56a570f

TolisChal pushed a commit that referenced this pull request Jul 17, 2024

Autopoint (#256)

f1bcd0c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autopoint #256

Autopoint #256

zhanggiene commented Dec 25, 2022

vissarion left a comment •

edited

Loading

vissarion Jan 3, 2023

papachristoumarios Jan 3, 2023

zhanggiene Jan 28, 2023

papachristoumarios Jan 3, 2023

papachristoumarios Jan 3, 2023

zhanggiene Jan 28, 2023

papachristoumarios Jan 3, 2023 •

edited

Loading

papachristoumarios Jan 3, 2023

zhanggiene Jan 28, 2023

papachristoumarios Feb 3, 2023

zhanggiene commented Jan 28, 2023

codecov bot commented Feb 4, 2023 •

edited

Loading

vissarion Feb 14, 2023

vissarion Feb 14, 2023

vfisikop commented Mar 6, 2024

		TARGET_LINK_LIBRARIES(Gaussian_mixture_autopoint ${LP_SOLVE} ${BLAS} autodiff::autodiff "-L${MKLROOT}/lib/intel64 -Wl,--no-as-needed -lmkl_intel_ilp64 -lmkl_gnu_thread -lmkl_core -lgomp -lpthread -lm -ldl")


		add_executable (MultidimensionalGaussian_mixture_autopoint MultidimensionalGaussian_mixture_autopoint.cpp readData.cpp)



		### Background information
		Autopoint is implemented using AUtodiff Library , after experiments of comparing various automatic differentiating libraries.Read [here](https://gist.github.com/zhanggiene/8471601fa25ba9db90303661b0e2237b) to find out more!

		@@ -392,4 +398,105 @@ struct HessianFunctor {

		};


		struct AutoDiffFunctor

Autopoint #256

Autopoint #256

Conversation

zhanggiene commented Dec 25, 2022

vissarion left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

papachristoumarios Jan 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhanggiene commented Jan 28, 2023

codecov bot commented Feb 4, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vfisikop commented Mar 6, 2024

vissarion left a comment •

edited

Loading

papachristoumarios Jan 3, 2023 •

edited

Loading

codecov bot commented Feb 4, 2023 •

edited

Loading