Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable code coverage #188

Merged
merged 11 commits into from
Oct 18, 2021
Merged

Enable code coverage #188

merged 11 commits into from
Oct 18, 2021

Conversation

vaithak
Copy link
Collaborator

@vaithak vaithak commented Oct 15, 2021

No description provided.

@vissarion vissarion linked an issue Oct 15, 2021 that may be closed by this pull request
Code coverage for volesti #139
Closed
@vaithak vaithak force-pushed the codecov branch 5 times, most recently from 63ec2ca to 2a10cec Compare October 15, 2021 19:06
@vaithak vaithak marked this pull request as ready for review October 16, 2021 21:24
@vaithak
Copy link
Collaborator Author

vaithak commented Oct 17, 2021

There is one issue with the current implementation, if there is a header file that is completely untouched by any test, then it won't affect the coverage at all (ideally it should be counted as 0% coverage). There are many questions/issues created for this, stackoverflow-link-1, github-issue-1, github-issue-2. One workaround for that is we manually see that if a new header file is added, then there must be at least one test using it.

@vissarion
Copy link
Member

There is one issue with the current implementation, if there is a header file that is completely untouched by any test, then it won't affect the coverage at all (ideally it should be counted as 0% coverage). There are many questions/issues created for this, stackoverflow-link-1, github-issue-1, github-issue-2. One workaround for that is we manually see that if a new header file is added, then there must be at least one test using it.

Good to note it down, but I think the project can live with that.

@vissarion vissarion merged commit f8ba770 into GeomScale:develop Oct 18, 2021
@vissarion
Copy link
Member

Many thanks @vaithak ! Now one can open an issue to improve code coverage ;)

@vissarion vissarion mentioned this pull request Oct 20, 2021
Closed
@vaithak vaithak mentioned this pull request Nov 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vissarion vissarion vissarion approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code coverage for volesti
2 participants
@vaithak @vissarion