Max inscribed ellipsoid sparse #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TolisChal
reviewed
Jul 19, 2021
| E2.noalias() = (A_trans * Y * A).inverse(); | ||
| Y = y.asDiagonal(); | ||
|
|
||
| E2.noalias() = MT(A_trans * Y * A).inverse(); |
There was a problem hiding this comment.
Since Y is a diagonal matrix, could this operation be further optimized?
There was a problem hiding this comment.
Y is defined to be of type Diagonal Matrix, so Eigen will optimize the multiplication as expected.
TolisChal
reviewed
Jul 19, 2021
| @@ -84,7 +95,7 @@ std::pair<std::pair<MT, VT>, bool> max_inscribed_ellipsoid(MT A, VT b, VT const& | |||
| vec_iter3++; | |||
| } | |||
| Q *= (t * t); | |||
| Y *= (1.0 / (t * t)); | |||
| Y = Y * (1.0 / (t * t)); | |||
There was a problem hiding this comment.
Since Y is a diagonal matrix, could this operation be further optimized?
There was a problem hiding this comment.
same here also, .asDiagonal() returns a diagonal matrix for which computations will be optimized.
I read about this from here: stackoverflow-answer
TolisChal
reviewed
Jul 19, 2021
| @@ -140,7 +151,7 @@ std::pair<std::pair<MT, VT>, bool> max_inscribed_ellipsoid(MT A, VT b, VT const& | |||
| YQ.noalias() = Y * Q; | |||
| G = YQ.cwiseProduct(YQ.transpose()); | |||
| y2h = 2.0 * yh; | |||
| YA.noalias() = Y * A; | |||
| YA = Y * A; | |||
There was a problem hiding this comment.
Since Y is a diagonal matrix, could this operation be further optimized?
There was a problem hiding this comment.
same as above, also A can be sparse here.
TolisChal
reviewed
Jul 19, 2021
vissarion
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_inscribed_ellipsoid_roundingmax_inscribed_ellipsoidfor polytopes with sparseAmatrix (for ex. order polytopes).