-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Count linear extensions using hpolytope #161
Count linear extensions using hpolytope #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I am ok with merging after fixing some minor issues.
examples/count-linear-extensions-using-hpolytope/volesti_lecount.cpp
Outdated
Show resolved
Hide resolved
examples/count-linear-extensions-using-hpolytope/volesti_lecount.cpp
Outdated
Show resolved
Hide resolved
return 0; | ||
} | ||
|
||
std::cout<<calculateLinearExtension(args)<<"\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use spaces around operators i.e. <<
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added spaces 👍
@@ -0,0 +1,8 @@ | |||
0 0 0 0 1 0 1 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add the source of the file and how you generated in a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generated it using the instances given in the le-counting-practice repo. Should I add the details in README file or a comment in C++ source code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I was thinking of adding the plots of corresponding DAGs of these instances in the README file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generated it using the instances given in the le-counting-practice repo. Should I add the details in README file or a comment in C++ source code?
README should be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added info regarding sample instances in the README file.
51fb5e8
to
e9f2591
Compare
@vaithak Thank you very much for this PR! |
This pull request provides an example for (approximately) counting the number of linear extensions of a post using volume computation of the order polytope (currently represented as an instance of hpolytope).