Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count linear extensions using hpolytope #161

Merged

Conversation

vaithak
Copy link
Collaborator

@vaithak vaithak commented Jun 4, 2021

This pull request provides an example for (approximately) counting the number of linear extensions of a post using volume computation of the order polytope (currently represented as an instance of hpolytope).

Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I am ok with merging after fixing some minor issues.

return 0;
}

std::cout<<calculateLinearExtension(args)<<"\n";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use spaces around operators i.e. <<

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added spaces 👍

@@ -0,0 +1,8 @@
0 0 0 0 1 0 1 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add the source of the file and how you generated in a comment?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generated it using the instances given in the le-counting-practice repo. Should I add the details in README file or a comment in C++ source code?

Copy link
Collaborator Author

@vaithak vaithak Jun 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I was thinking of adding the plots of corresponding DAGs of these instances in the README file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generated it using the instances given in the le-counting-practice repo. Should I add the details in README file or a comment in C++ source code?

README should be fine

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added info regarding sample instances in the README file.

@vaithak vaithak force-pushed the count-linear-extensions-using-hpolytope branch from 51fb5e8 to e9f2591 Compare June 10, 2021 15:25
@vissarion vissarion self-requested a review June 11, 2021 08:52
@TolisChal
Copy link
Member

@vaithak Thank you very much for this PR!
These are nice examples.

@TolisChal TolisChal merged commit ea415b1 into GeomScale:develop Jun 11, 2021
@vaithak vaithak deleted the count-linear-extensions-using-hpolytope branch June 30, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants