Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MPI variable in utilities.cc from int to unsigned int. #774

Merged

Conversation

MFraters
Copy link
Member

resolves #770. @anne-glerum, could you confirm this solves the issue for you?

Copy link

github-actions bot commented Dec 10, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.211 ± 0.011 (s=382) 1.212 ± 0.011 (s=363) -0.1% .. +0.3%
Slab interpolation curved simple none 1.210 ± 0.008 (s=383) 1.211 ± 0.014 (s=363) -0.1% .. +0.4%
Spherical slab interpolation simple none 1.224 ± 0.009 (s=345) 1.226 ± 0.011 (s=392) -0.1% .. +0.3%
Slab interpolation simple curved CMS 1.253 ± 0.011 (s=353) 1.253 ± 0.012 (s=368) -0.2% .. +0.2%
Spherical slab interpolation simple CMS 1.639 ± 0.014 (s=280) 1.640 ± 0.015 (s=272) -0.1% .. +0.3%
Spherical fault interpolation simple none 1.231 ± 0.010 (s=382) 1.232 ± 0.011 (s=351) -0.1% .. +0.3%
Cartesian min max surface 2.731 ± 0.028 (s=145) 2.731 ± 0.022 (s=187) -0.4% .. +0.4%
Spherical min max surface 7.745 ± 0.049 (s=54) 7.741 ± 0.069 (s=65) -0.5% .. +0.4%

@MFraters MFraters force-pushed the fix_mpi_unsigned_int_warning branch from dd8ae54 to f18fbc1 Compare December 10, 2024 14:47
@anne-glerum
Copy link
Contributor

Confirmed! This fixes the compiler warnings on my machine.

@MFraters
Copy link
Member Author

Thanks for confirming!

@MFraters MFraters merged commit 89c1811 into GeodynamicWorldBuilder:main Dec 11, 2024
36 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler warnings Mac Ventura
3 participants