Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add velocity infrastructure. #761

Merged

Conversation

MFraters
Copy link
Member

This pull request implements #528. It is still very rudementary and a work in progress.

I am thinking of renaming the current uniform models to raw, since they just work with raw velocity input. I think the uniform model should be more useful, given that it is usually the simple default model. I think uniform in this case should not make the same value everywhere (which is would raw (constant?) would be, but for example uniform in continent would provide a direction, dip and magnitude (which is more like how the rest of the models work, 2d top down + dip) and for a slab or fault it would be relative to the slab geometry. In spherical uniform should also be relative to the geometry.

Example of current functionality:
image

@MFraters MFraters added add/change code functionality Requests or proposes new or improved code (internal) functionality add/change user functionality Requests or proposes a new or improved user functionality labels Oct 13, 2024
@MFraters MFraters force-pushed the add_velocity_infrastructure branch from b9c1f3f to 7f635d0 Compare October 14, 2024 10:25
Copy link

github-actions bot commented Oct 14, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 0.992 ± 0.005 (s=430) 1.194 ± 0.011 (s=399) +20.1% .. +20.5%
Slab interpolation curved simple none 0.993 ± 0.004 (s=399) 1.195 ± 0.013 (s=424) +20.1% .. +20.5%
Spherical slab interpolation simple none 1.161 ± 0.008 (s=369) 1.209 ± 0.011 (s=392) +3.9% .. +4.3%
Slab interpolation simple curved CMS 1.038 ± 0.005 (s=403) 1.235 ± 0.012 (s=392) +18.7% .. +19.1%
Spherical slab interpolation simple CMS 1.566 ± 0.010 (s=267) 1.624 ± 0.015 (s=299) +3.5% .. +3.9%
Spherical fault interpolation simple none 1.166 ± 0.009 (s=384) 1.215 ± 0.011 (s=375) +4.0% .. +4.4%
Cartesian min max surface 2.347 ± 0.045 (s=165) 2.707 ± 0.023 (s=192) +14.8% .. +15.9%
Spherical min max surface 7.031 ± 0.026 (s=81) 7.637 ± 0.113 (s=46) +7.8% .. +9.5%

@MFraters MFraters force-pushed the add_velocity_infrastructure branch 3 times, most recently from 189247f to 7c5b26c Compare October 20, 2024 10:38
@MFraters MFraters changed the title [WIP] add velocity infrastructure. add velocity infrastructure. Oct 20, 2024
@MFraters MFraters force-pushed the add_velocity_infrastructure branch from 7c5b26c to be1d85b Compare October 20, 2024 10:52
@MFraters
Copy link
Member Author

This is almost ready to merge I think. It also contains some other items, including an option to replace the reference results from any test that fails, and limiting the resolution of the doc_* tests to improve tester performance.

@MFraters MFraters force-pushed the add_velocity_infrastructure branch 6 times, most recently from c4e6c02 to 564be5e Compare October 20, 2024 13:52
@MFraters MFraters force-pushed the add_velocity_infrastructure branch from 564be5e to 076aad2 Compare October 20, 2024 13:53
@MFraters MFraters added the ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews. label Oct 20, 2024
@MFraters MFraters merged commit 062d91d into GeodynamicWorldBuilder:main Oct 20, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add/change code functionality Requests or proposes new or improved code (internal) functionality add/change user functionality Requests or proposes a new or improved user functionality ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant