Deprecate windows mingw gcc compiler in documentation #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tjhei
reviewed
Jul 28, 2024
| @@ -71,7 +71,7 @@ There are three main ways to install on Windows. | |||
| The recommended way is to use Linux subsystems for Windows (see <https://docs.microsoft.com/en-us/windows/wsl/install-win10>). | |||
| In this case, start Linux in the Windows terminal and follow the Linux installation description. | |||
|
|
|||
| If you want to have a native installation, the two main options are using MinGW or Visual Studio. | |||
| If you want to have a native installation, the two main options are using Visual Studio and MinGW. Note that the use of MinGW to compile the world builder is currently not supported (see https://github.com/GeodynamicWorldBuilder/WorldBuilder/issues/743 for more info). | |||
There was a problem hiding this comment.
I would remove mingw support, honestly. You have WSL and VS as two options on windows.
There was a problem hiding this comment.
yes, that might be better. I don't think it is worth spending more time on fixing this in the future.
There was a problem hiding this comment.
just my thoughts on this coming from deal.II:
- there were no users of it or at least we didn't hear form anyone over the years
- mingw has/had the tendency to ship broken features
- WSL is surprisingly good and I don't see a reason to use mingw
There was a problem hiding this comment.
Thanks, those are good arguments. I have now just removed MinGW support for the world builder.
MFraters
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update manual to deprecated Windows MinGW support for now as suggested in #743.