Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to WB matrix room in documentation #545

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

gassmoeller
Copy link
Contributor

For some reason this link doesnt show up correctly in the documentation. This is an attempt to fix it. Dont merge until I have checked the documentation tester.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d465a69) 93.49% compared to head (e25ce1e) 93.49%.
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files          92       92           
  Lines        6346     6346           
=======================================
  Hits         5933     5933           
  Misses        413      413           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d465a69...e25ce1e. Read the comment docs.

Copy link

github-actions bot commented Feb 13, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.020 ± 0.002 (s=451) 1.020 ± 0.004 (s=434) -0.0% .. +0.1%
Slab interpolation curved simple none 1.025 ± 0.005 (s=419) 1.025 ± 0.003 (s=462) -0.1% .. +0.1%
Spherical slab interpolation simple none 1.263 ± 0.005 (s=354) 1.262 ± 0.005 (s=361) -0.2% .. -0.0%
Slab interpolation simple curved CMS 1.106 ± 0.004 (s=412) 1.106 ± 0.004 (s=404) -0.0% .. +0.1%
Spherical slab interpolation simple CMS 1.860 ± 0.007 (s=245) 1.860 ± 0.008 (s=241) -0.1% .. +0.1%
Spherical fault interpolation simple none 1.272 ± 0.004 (s=360) 1.273 ± 0.008 (s=350) -0.1% .. +0.2%
Cartesian min max surface 2.367 ± 0.019 (s=186) 2.367 ± 0.023 (s=197) -0.3% .. +0.3%
Spherical min max surface 7.366 ± 0.086 (s=60) 7.353 ± 0.023 (s=65) -0.7% .. +0.4%

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, that didn't work. Could you try the html code instead: &num;?

@gassmoeller
Copy link
Contributor Author

&num; didnt work, but the percent encoding %23 did the trick (https://www.w3schools.com/tags/ref_urlencode.ASP).

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for fixing this!

@MFraters MFraters added the ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews. label Feb 13, 2024
@MFraters MFraters merged commit 87e86f2 into GeodynamicWorldBuilder:main Feb 13, 2024
33 of 34 checks passed
@gassmoeller gassmoeller deleted the fix_chat_link branch February 13, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants