Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date for v0.5.0 in citation #517

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

ljhwang
Copy link
Contributor

@ljhwang ljhwang commented Oct 13, 2023

Fixes the year for the citation to the software for v0.5.0 to 2023.

Also changes the day of the month to align with the citation on Zenodo.

This may not change everywhere where the citation is incorrect. Only the places I noticed :)

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #517 (28c2d62) into main (a280aa9) will not change coverage.
The diff coverage is n/a.

❗ Current head 28c2d62 differs from pull request most recent head db3ec71. Consider uploading reports for the commit db3ec71 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files          92       92           
  Lines        6279     6279           
=======================================
  Hits         5868     5868           
  Misses        411      411           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a280aa9...db3ec71. Read the comment docs.

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the fix!

@github-actions
Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.188 ± 0.006 (s=384) 1.187 ± 0.005 (s=376) -0.2% .. +0.1%
Slab interpolation curved simple none 1.270 ± 0.006 (s=360) 1.269 ± 0.005 (s=351) -0.1% .. +0.1%
Spherical slab interpolation simple none 1.489 ± 0.006 (s=302) 1.488 ± 0.005 (s=305) -0.2% .. +0.0%
Slab interpolation simple curved CMS 1.576 ± 0.027 (s=304) 1.575 ± 0.025 (s=270) -0.5% .. +0.4%
Spherical slab interpolation simple CMS 2.928 ± 0.073 (s=156) 2.919 ± 0.062 (s=154) -1.2% .. +0.5%
Spherical fault interpolation simple none 1.511 ± 0.006 (s=319) 1.512 ± 0.008 (s=279) -0.1% .. +0.2%
Cartesian min max surface 3.004 ± 0.016 (s=148) 3.006 ± 0.016 (s=154) -0.1% .. +0.3%
Spherical min max surface 9.603 ± 0.398 (s=52) 9.617 ± 0.433 (s=44) -2.9% .. +3.2%

@MFraters MFraters merged commit 425cdf8 into GeodynamicWorldBuilder:main Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants