Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composition operations #474

Merged
merged 7 commits into from
Feb 18, 2023

Conversation

MFraters
Copy link
Member

The pull requests expand the operation enum and functions for the compositional plugins and lets them use it.

@MFraters MFraters force-pushed the composition_operations branch from 41d14a2 to ed7474b Compare February 17, 2023 17:23
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #474 (c79e54f) into main (47a54c2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c79e54f differs from pull request most recent head e98dd27. Consider uploading reports for the commit e98dd27 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   90.80%   90.80%   -0.01%     
==========================================
  Files          90       90              
  Lines        6371     6370       -1     
==========================================
- Hits         5785     5784       -1     
  Misses        586      586              
Impacted Files Coverage Δ
...fault_models/grains/random_uniform_distribution.cc 98.52% <ø> (ø)
...ld_builder/features/fault_models/grains/uniform.cc 97.87% <ø> (ø)
...plate_models/grains/random_uniform_distribution.cc 98.52% <ø> (ø)
...features/subducting_plate_models/grains/uniform.cc 95.74% <ø> (ø)
...es/continental_plate_models/composition/uniform.cc 100.00% <100.00%> (ø)
.../continental_plate_models/temperature/adiabatic.cc 100.00% <100.00%> (ø)
...res/continental_plate_models/temperature/linear.cc 100.00% <100.00%> (ø)
...es/continental_plate_models/temperature/uniform.cc 100.00% <100.00%> (ø)
source/world_builder/features/fault.cc 99.63% <100.00%> (ø)
...uilder/features/fault_models/composition/smooth.cc 97.29% <100.00%> (+0.23%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47a54c2...e98dd27. Read the comment docs.

@MFraters MFraters force-pushed the composition_operations branch from ed7474b to 37fcdaf Compare February 17, 2023 17:38
@github-actions
Copy link

github-actions bot commented Feb 17, 2023

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.419 ± 0.009 (s=321) 1.423 ± 0.010 (s=315) +0.1% .. +0.5%
Slab interpolation curved simple none 1.200 ± 0.005 (s=361) 1.203 ± 0.003 (s=391) +0.1% .. +0.3%
Spherical slab interpolation simple none 1.572 ± 0.011 (s=306) 1.568 ± 0.004 (s=270) -0.4% .. -0.1%
Slab interpolation simple curved CMS 1.377 ± 0.003 (s=326) 1.376 ± 0.003 (s=330) -0.2% .. -0.1%
Spherical slab interpolation simple CMS 2.273 ± 0.012 (s=213) 2.273 ± 0.006 (s=185) -0.2% .. +0.1%
Spherical fault interpolation simple none 1.596 ± 0.010 (s=266) 1.593 ± 0.003 (s=301) -0.4% .. -0.1%
Cartesian min max surface 3.076 ± 0.017 (s=143) 3.048 ± 0.019 (s=153) -1.1% .. -0.7%
Spherical min max surface 9.328 ± 0.017 (s=55) 9.312 ± 0.019 (s=44) -0.3% .. -0.0%

@MFraters MFraters force-pushed the composition_operations branch from 37fcdaf to fedabb2 Compare February 18, 2023 01:20
@MFraters MFraters force-pushed the composition_operations branch from fedabb2 to eddd075 Compare February 18, 2023 01:42
@MFraters MFraters changed the title [WIP] Composition operations Composition operations Feb 18, 2023
@MFraters MFraters merged commit 9f8be6f into GeodynamicWorldBuilder:main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant