Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace INFINITY by std::numeric_limits. #363

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

bangerth
Copy link
Contributor

@bangerth bangerth commented Nov 3, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #363 (6ab538b) into main (462d2a3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files          77       77           
  Lines        4472     4472           
=======================================
  Hits         4421     4421           
  Misses         51       51           
Impacted Files Coverage Δ
source/features/fault.cc 99.17% <100.00%> (ø)
source/features/subducting_plate.cc 99.17% <100.00%> (ø)
source/utilities.cc 98.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 462d2a3...6ab538b. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.348 ± 0.036 (s=332) 1.352 ± 0.036 (s=337) -0.3% .. +1.0%
Slab interpolation curved simple none 1.307 ± 0.027 (s=350) 1.310 ± 0.029 (s=340) -0.3% .. +0.8%
Spherical slab interpolation simple none 1.586 ± 0.075 (s=276) 1.587 ± 0.072 (s=294) -1.2% .. +1.4%
Slab interpolation simple curved CMS 2.205 ± 0.026 (s=201) 2.199 ± 0.023 (s=210) -0.6% .. +0.1%
Spherical slab interpolation simple CMS 3.063 ± 0.057 (s=161) 3.067 ± 0.063 (s=135) -0.6% .. +0.9%
Spherical fault interpolation simple none 1.758 ± 0.022 (s=250) 1.757 ± 0.021 (s=265) -0.4% .. +0.3%

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in #331, this a better way of setting infinity. Thanks!

@MFraters MFraters merged commit f0144eb into GeodynamicWorldBuilder:main Nov 5, 2021
@bangerth bangerth deleted the infinity branch November 5, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants