database integration. using id from database of OGW-Microservice's da… #92
Conversation
…tabase rm filename from register json schema new functions for data_file_path get_data_info, get_data_file_path, load_data
…ta_helpers. Is test_data_helpers needed ?
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
mypy
🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation [no-untyped-def]
OpenGeodeWeb-Viewer/src/tests/conftest.py
Line 127 in 4ce8770
🚫 [mypy] reported by reviewdog 🐶
Call to untyped function "call" in typed context [no-untyped-call]
OpenGeodeWeb-Viewer/src/tests/conftest.py
Line 137 in 4ce8770
🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation [no-untyped-def]
OpenGeodeWeb-Viewer/src/tests/conftest.py
Line 139 in 4ce8770
🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation [no-untyped-def]
OpenGeodeWeb-Viewer/src/tests/conftest.py
Line 200 in 4ce8770
🚫 [mypy] reported by reviewdog 🐶
Call to untyped function "_seed_database" in typed context [no-untyped-call]
OpenGeodeWeb-Viewer/src/tests/conftest.py
Line 295 in 4ce8770
🚫 [mypy] reported by reviewdog 🐶
Untyped decorator makes function "dataset_factory" untyped [misc]
OpenGeodeWeb-Viewer/src/tests/conftest.py
Line 307 in 4ce8770
🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation [no-untyped-def]
OpenGeodeWeb-Viewer/src/tests/conftest.py
Line 327 in 4ce8770
🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation [no-untyped-def]
🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation [no-untyped-def]
🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation [no-untyped-def]
🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation [no-untyped-def]
🚫 [mypy] reported by reviewdog 🐶
Call to untyped function "DatabaseManager" in typed context [no-untyped-call]
🚫 [mypy] reported by reviewdog 🐶
Module "src.opengeodeweb_viewer.database.connection" does not explicitly export attribute "Data" [attr-defined]
🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation [no-untyped-def]
🚫 [mypy] reported by reviewdog 🐶
Call to untyped function "get_session" in typed context [no-untyped-call]
🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation [no-untyped-def]
🚫 [mypy] reported by reviewdog 🐶
Call to untyped function "get_data" in typed context [no-untyped-call]
🚫 [mypy] reported by reviewdog 🐶
Argument 1 to "join" has incompatible type "str | None"; expected "str" [arg-type]
🚫 [mypy] reported by reviewdog 🐶
Call to untyped function "get_data_base" in typed context [no-untyped-call]
🚫 [mypy] reported by reviewdog 🐶
Call to untyped function "get_data_base" in typed context [no-untyped-call]
missing viewer_object = self.get_viewer_object_type(params["id"])
| if Data is None: | ||
| raise Exception("Data model not available") | ||
|
|
||
| with get_session() as session: |
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
"scoped_session[Session]" has no attribute "enter"; maybe "iter"? [attr-defined]
| if Data is None: | ||
| raise Exception("Data model not available") | ||
|
|
||
| with get_session() as session: |
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
"scoped_session[Session]" has no attribute "exit" [attr-defined]
…tabase
rm filename from register json schema
new functions for data_file_path get_data_info, get_data_file_path, load_data