-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MeshHelpers): add PointSetMerger class. #944
Conversation
} | ||
|
||
template < index_t dimension > | ||
PointSetMerger< dimension >::~PointSetMerger() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use =default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
||
#pragma once | ||
|
||
#include <absl/types/span.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'absl/types/span.h' file not found [clang-diagnostic-error]
#include <absl/types/span.h>
^
#include <geode/mesh/common.h> | ||
#include <geode/mesh/helpers/detail/vertex_merger.h> | ||
|
||
namespace geode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: variable 'geode' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
namespace geode
^
FORWARD_DECLARATION_DIMENSION_CLASS( PointSet ); | ||
} // namespace geode | ||
|
||
namespace geode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: variable 'geode' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
namespace geode
^
* | ||
*/ | ||
|
||
#include <geode/mesh/helpers/detail/point_set_merger.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'geode/mesh/helpers/detail/point_set_merger.h' file not found [clang-diagnostic-error]
#include <geode/mesh/helpers/detail/point_set_merger.h>
^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -55,11 +56,15 @@ namespace geode | |||
return Mesh::create( geode::MeshFactory::default_impl( type ) ); | |||
} | |||
|
|||
template std::unique_ptr< PointSet2D > opengeode_mesh_api create_mesh( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: variable 'opengeode_mesh_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
template std::unique_ptr< PointSet2D > opengeode_mesh_api create_mesh(
^
template std::unique_ptr< EdgedCurve2D > opengeode_mesh_api create_mesh( | ||
absl::Span< const std::reference_wrapper< const EdgedCurve2D > > ); | ||
template std::unique_ptr< SurfaceMesh2D > | ||
opengeode_mesh_api create_mesh( absl::Span< | ||
const std::reference_wrapper< const SurfaceMesh2D > > ); | ||
template std::unique_ptr< PointSet3D > opengeode_mesh_api create_mesh( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: variable 'opengeode_mesh_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
template std::unique_ptr< PointSet3D > opengeode_mesh_api create_mesh(
^
🎉 This PR is included in version 14.25.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 14.25.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.