fix(IO): enable export of 8bit-valued attributes to Paraview #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelchiorSchuh
changed the base branch from
next
to
add_local_index_t_to_exportable_attributes
MelchiorSchuh
merged commit 6aed0eb
into
Geode-solutions:add_local_index_t_to_exportable_attributes
5 of 6 checks passed
|
🎉 This PR is included in version 14.12.2-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 14.12.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The use-case is to be able to export a
geode::EdgedCurve3Dmesh with its attributes -- one of them being valued as 8-bit integers (aka.geode::local_index_t) -- to Paraview (through the .vtp file format).Currently, 8-bit-valued attributes are not exported in Paraview .vtp files. From what I understand in the code in OpenGeodeIO, this is because these attributes are not flaggued as "genericable". The PR fixes that, but it modifies the core lib, and I'm not able to assess all the possible impacts...