Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(Algorithm): increase allowed parameter types #875

Merged
merged 1 commit into from
Dec 18, 2023
Merged

perf(Algorithm): increase allowed parameter types #875

merged 1 commit into from
Dec 18, 2023

Conversation

BotellaA
Copy link
Member

No description provided.

@github-actions github-actions bot changed the base branch from master to next December 17, 2023 21:06
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

MelchiorSchuh
MelchiorSchuh approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@MelchiorSchuh MelchiorSchuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que les méthodes portent encore bien leur nom, si elles ne sont pplus sur des std::vector ?

@BotellaA
Copy link
Member Author

Est-ce que les méthodes portent encore bien leur nom, si elles ne sont pplus sur des std::vector ?

Je suis accord mais c'est dommage de faire une majeure pour ca...

@panquez panquez merged commit fc3882f into next Dec 18, 2023
45 checks passed
@panquez panquez deleted the perf/algorithm branch December 18, 2023 09:52
@BotellaA
Copy link
Member Author

🎉 This PR is included in version 14.10.5-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA
Copy link
Member Author

🎉 This PR is included in version 14.10.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panquez panquez panquez approved these changes

@MelchiorSchuh MelchiorSchuh MelchiorSchuh approved these changes

@francoisbonneau francoisbonneau francoisbonneau approved these changes

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BotellaA @francoisbonneau @MelchiorSchuh @panquez