fix(Return): remove [[nodiscard]] specifier on find_or_create_attribute(..)

[yo35]

It may be relevant to ignore the pointer returned by find_or_create_attribute(..) if the caller just wants to create the attribute (or to ensure it exists).

[BotellaA]

This is no likely to be accepted. Why do you need that?

You can use a workaround using either geode_unused function of [[maybe_unused]] keyword.

[yo35]

Hi @BotellaA . Answer in main thread.

[yo35]

I need that to create an attribute, but I don't need the pointer returned by the method. And there could be several reasons why I don't need it:

• because the attribute that is created is constant,
• because the creation and the modification of the attribute in the calling lib is not performed at the same place (e.g. the former in a sequential segment, the latter in a parallel segment),
• etc...

More generally, in my opinion, [[nodiscard]] should not be applied to a method whose purpose is to change the state of one of its argument (i.e. to perform a side-effect operation).

[yo35]

Thanks @BotellaA

[BotellaA]

🎉 This PR is included in version 15.6.7-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[BotellaA]

🎉 This PR is included in version 15.6.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀