fix(BasicObjects): add is_degenerated #1032
Conversation
BotellaA
force-pushed
the
fix/basic-obj-degen
branch
from
e0d00ca to
ff0fe6b
Compare
| return point_line_distance( | ||
| point2, InfiniteLine< dimension >{ edge } ) | ||
| <= GLOBAL_EPSILON; |
There was a problem hiding this comment.
Not a return her, but if <= GLOBAL_EPSILON return true
| point2, InfiniteLine< dimension >{ edge } ) | ||
| <= GLOBAL_EPSILON; | ||
| } | ||
| return true; |
| return std::get< 0 >( | ||
| point_plane_distance( point3, Plane{ triangle } ) ) | ||
| <= GLOBAL_EPSILON; |
There was a problem hiding this comment.
not a return here. but if <= GLOBAL_EPSILON then return true, else go for the next tetrahedron_facet
There was a problem hiding this comment.
Or you do not have to iterates in the 4 facets, since you will directly have an answer on the first tested facet
There was a problem hiding this comment.
Might be enough... If it is degen then the simplex is degen, is not the distance once should be enough to determine since we are in a simplex. What do you think?
| <= GLOBAL_EPSILON; | ||
| } | ||
| } | ||
| return true; |
There was a problem hiding this comment.
return false, if it is ok for all 4 facets
…nto fix/basic-obj-degen
|
🎉 This PR is included in version 15.5.4-rc.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 15.5.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.