Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ProgressLogger): add refresh interval setter #1011

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

BotellaA
Copy link
Member

@BotellaA BotellaA commented Sep 3, 2024

@yo35 This is another proposition from your PR. Is it ok for you?

@yo35
Copy link
Contributor

yo35 commented Sep 3, 2024

@BotellaA Thanks Arnaud. This solution is OK as well for our use-case.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/geode/basic/progress_logger.hpp Show resolved Hide resolved
@MelchiorSchuh MelchiorSchuh merged commit f314124 into next Sep 3, 2024
19 checks passed
@MelchiorSchuh MelchiorSchuh deleted the fix/progress-logger-refresh branch September 3, 2024 10:59
@BotellaA
Copy link
Member Author

BotellaA commented Sep 3, 2024

🎉 This PR is included in version 15.2.6-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA
Copy link
Member Author

BotellaA commented Sep 4, 2024

🎉 This PR is included in version 15.2.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants