Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bounding Box): add method to get the largest axe of the BBox #1003

Merged
merged 9 commits into from
Aug 12, 2024

Conversation

panquez
Copy link
Member

@panquez panquez commented Aug 2, 2024

Do you see an interest to this method?

@panquez panquez requested a review from BotellaA August 2, 2024 14:34
Copy link
Contributor

github-actions bot commented Aug 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/geode/geometry/bounding_box.cpp Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/geode/basic/algorithm.hpp Outdated Show resolved Hide resolved
@MelchiorSchuh MelchiorSchuh merged commit cf0296f into next Aug 12, 2024
20 checks passed
@MelchiorSchuh MelchiorSchuh deleted the fix/bbox-large branch August 12, 2024 07:29
@BotellaA
Copy link
Member

🎉 This PR is included in version 15.2.1-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA
Copy link
Member

🎉 This PR is included in version 15.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants