Merge pull request #879 from Geode-solutions/fix/less-no-lint

fix(default): add more default destructors
Geode-solutions · Jan 3, 2024 · 40b4f90 · 40b4f90
2 parents 58baad8 + 6ea5d98
commit 40b4f90
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 22 deletions.
diff --git a/src/geode/basic/cell_array.cpp b/src/geode/basic/cell_array.cpp
@@ -121,9 +121,7 @@ namespace geode
     };
 
     template < index_t dimension >
-    CellArray< dimension >::CellArray() // NOLINT
-    {
-    }
+    CellArray< dimension >::CellArray() = default;
 
     template < index_t dimension >
     CellArray< dimension >::CellArray(
@@ -140,9 +138,7 @@ namespace geode
         -> CellArray& = default;
 
     template < index_t dimension >
-    CellArray< dimension >::~CellArray() // NOLINT
-    {
-    }
+    CellArray< dimension >::~CellArray() = default;
 
     template < index_t dimension >
     index_t CellArray< dimension >::nb_cells() const

diff --git a/src/geode/geometry/bounding_box.cpp b/src/geode/geometry/bounding_box.cpp
@@ -101,7 +101,7 @@ namespace
 namespace geode
 {
     template < index_t dimension >
-    BoundingBox< dimension >::BoundingBox() // NOLINT
+    BoundingBox< dimension >::BoundingBox()
     {
         for( const auto i : LRange{ dimension } )
         {

diff --git a/src/geode/mesh/core/surface_edges.cpp b/src/geode/mesh/core/surface_edges.cpp
@@ -101,9 +101,7 @@ namespace geode
     }
 
     template < index_t dimension >
-    SurfaceEdges< dimension >::~SurfaceEdges() // NOLINT
-    {
-    }
+    SurfaceEdges< dimension >::~SurfaceEdges() = default;
 
     template < index_t dimension >
     index_t SurfaceEdges< dimension >::find_or_create_edge(

diff --git a/src/geode/mesh/helpers/detail/component_identifier.cpp b/src/geode/mesh/helpers/detail/component_identifier.cpp
@@ -168,9 +168,7 @@ namespace geode
         {
         }
 
-        GraphIdentifier::~GraphIdentifier() // NOLINT
-        {
-        }
+        GraphIdentifier::~GraphIdentifier() = default;
 
         index_t GraphIdentifier::identify_vertices()
         {
@@ -227,9 +225,7 @@ namespace geode
         }
 
         template < index_t dimension >
-        EdgedCurveIdentifier< dimension >::~EdgedCurveIdentifier() // NOLINT
-        {
-        }
+        EdgedCurveIdentifier< dimension >::~EdgedCurveIdentifier() = default;
 
         template < index_t dimension >
         index_t EdgedCurveIdentifier< dimension >::identify_edges()
@@ -282,9 +278,7 @@ namespace geode
         }
 
         template < index_t dimension >
-        SurfaceIdentifier< dimension >::~SurfaceIdentifier() // NOLINT
-        {
-        }
+        SurfaceIdentifier< dimension >::~SurfaceIdentifier() = default;
 
         template < index_t dimension >
         index_t SurfaceIdentifier< dimension >::identify_polygons()
@@ -330,9 +324,7 @@ namespace geode
         {
         }
 
-        SolidIdentifier::~SolidIdentifier() // NOLINT
-        {
-        }
+        SolidIdentifier::~SolidIdentifier() = default;
 
         index_t SolidIdentifier::identify_polyhedra()
         {