Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: remove tests with np.int which is a deprecated alias for buitin int #148

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Tests: remove tests with np.int which is a deprecated alias for buitin int #148

merged 1 commit into from
Mar 26, 2021

Conversation

MuellerSeb
Copy link
Member

@MuellerSeb MuellerSeb added the FutureWarning Aim is to prevent FutureWarnings when they appear. label Mar 22, 2021
@MuellerSeb MuellerSeb added this to the 1.3 milestone Mar 22, 2021
@MuellerSeb MuellerSeb requested a review from LSchueler March 22, 2021 20:52
@MuellerSeb MuellerSeb self-assigned this Mar 22, 2021
@MuellerSeb
Copy link
Member Author

CI currently failing for linux wheels because of this: https://status.quay.io/

@MuellerSeb
Copy link
Member Author

Windows wheels still failing since #147 is not merged.

LSchueler
LSchueler approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't even remember why I tested int and np.int...

@MuellerSeb MuellerSeb merged commit ae2f672 into develop Mar 26, 2021
@MuellerSeb MuellerSeb deleted the fix_deprecation_warn_npint branch March 26, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LSchueler LSchueler LSchueler approved these changes

Assignees

@MuellerSeb MuellerSeb

Labels
FutureWarning Aim is to prevent FutureWarnings when they appear.
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@MuellerSeb @LSchueler