Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 4.4.x] [Fixes #12627] Include assets inside B/R #12634

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 7, 2024

Backport 33be915 from #12628.

* [Fixes #12627] Include assets inside B/R
* [Fixes #12627] force localasset in get_link_url
* [Fixes #12627] fix pr comments
* [Fixes #12627] add todo for assets_root replace
* [Fixes #12627] change utils assets_root name

(cherry picked from commit 33be915)
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 7, 2024
@mattiagiupponi mattiagiupponi self-requested a review October 7, 2024 09:25
@mattiagiupponi mattiagiupponi merged commit 59ace1f into 4.4.x Oct 7, 2024
10 checks passed
@mattiagiupponi mattiagiupponi deleted the backport-12628-to-4.4.x branch October 7, 2024 09:55
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 35 lines in your changes missing coverage. Please review.

Project coverage is 64.16%. Comparing base (e0bf61a) to head (f89a8a0).
Report is 1 commits behind head on 4.4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##            4.4.x   #12634      +/-   ##
==========================================
- Coverage   64.18%   64.16%   -0.03%     
==========================================
  Files         889      889              
  Lines       53709    53748      +39     
  Branches     6621     6625       +4     
==========================================
+ Hits        34475    34487      +12     
- Misses      17723    17747      +24     
- Partials     1511     1514       +3     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant