Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GNIP 30 - Split out geonode.maps into 2 modules #273

Closed
sbenthall opened this issue Jun 5, 2012 · 8 comments
Closed

GNIP 30 - Split out geonode.maps into 2 modules #273

sbenthall opened this issue Jun 5, 2012 · 8 comments
Assignees
@jj0hns0n
Labels
gnip A GeoNodeImprovementProcess Issue
Milestone
2.0

Comments

@sbenthall
Copy link
Contributor

http://github.com/GeoNode/geonode/wiki/GNIP-30----Split-out-geonode.maps-into-2-modules

It is proposed to split the geonode.maps module into 2 separate modules: geonode.data (or geonode.layers) to handle all interactions with data itself, and geonode.maps to handle the maps. This reorganization would be used to reorganize each of the new constituent files (models.py, views.py etc) more logically (similar or related methods together) and to add docstrings for all methods in the process.

This change would require a database migration that django-south can't handle and so could involve some pain. On the other hand, it's intended to make things easier on developers.
@ghost ghost assigned jj0hns0n Jun 5, 2012
@sbenthall
Copy link
Contributor Author

Since this is a change intended to make things easier for developers, I think that other developers need to weigh in on it for it to be approved.

@simod
Copy link
Member

simod commented Jun 5, 2012

I'm +1 on this (by naming layers instead of data). Thanks!

@tomkralidis
Copy link
Member

+1

@jj0hns0n
Copy link
Member

jj0hns0n commented Jun 5, 2012

Im +1 on this obviously, and yes, I can see the logic in using the
name layers vs data.

On Tue, Jun 5, 2012 at 11:10 AM, Tom Kralidis
reply@reply.github.com
wrote:

+1

Reply to this email directly or view it on GitHub:
#273 (comment)

@rmarianski
Copy link
Contributor

+1.

Just out of curiosity, will we be able to provide a migration story outside of south?

@jj0hns0n
Copy link
Member

jj0hns0n commented Jun 5, 2012

It takes some effort to use south to actually migrate data. Not sure
if we would want to do this though. This is why I've said it will be
complicated for people to upgrade a site after these changes, but Im
not sure that should prevent us from doing it. Ariel has some nice
management commands to backup and then restore a geonode, and they
could be a better way to do this.

On Tue, Jun 5, 2012 at 1:15 PM, Robert Marianski
reply@reply.github.com
wrote:

+1.

Just out of curiosity, will we be able to provide a migration story outside of south?

Reply to this email directly or view it on GitHub:
#273 (comment)

@rmarianski
Copy link
Contributor

Good idea. Due to the amount of reorganization that is going on, a backup/restore might be a nice way to tackle all the different model changes at once.

@jj0hns0n
Copy link
Member

Can we just close this since its done. Not sure about migrations, but the actual migration is done.

afabiani pushed a commit that referenced this issue Jun 5, 2018
@capooti
Fixes #273
a521cfc
afabiani pushed a commit that referenced this issue Oct 18, 2018
@capooti
PR with Worldmap changes running on master (2.10.x) (#3998)
942e286 
* Remove an ipdb line

* Enable DB_DATASTORE when using WorldMap

* Now it is possible to edit and style also from local dev

* Fixes #263

* Fixes #273

* Synced with geonode master

* Fixes a problem with layers upload

* Add url dispatcher for worldmap api

* WorldMap api version is now 2.8

* Added worldmap geoexplorer client source code. Fixes #265

* Fixed javascript build.xml and a few things in GeoExplorer.js

* Ported the action model and its api, which is needed by hypermap

* Updating instructions for geonode-worldmap

* Fixes #264

* Fixes #280

* Update instructions adding the configuration of update_last_wm_geonode_layers

* Trying to increase accesstoken expiration to see if this affects #283

* Removed google earth tool. Fixed the gxp_mapshare tool. Fixing google map api key read

* Adding a missing import which caused an error when looking at map page as anonymous user

* Migrate worldmap map revisions. Fixes #266

* Restore map print tool

* Fixes #267

* Fixes #260 (gazetteer)

* Forgot one requirement in previous commit

* Fixes #272

* Fixes permission issues with editing and use the correct source for wm layers

* Fixes #283

* Fixes #314

* Fixes #298

* Point to the correct warper site in the rectify images dialog

* Correctly identify a local layer when using GeoNodeQueryTool

* Fixes #322

* Fixes zoom to extent tool

* Fixes the regression casuing all the extent issues

* Fixes #301

* Release 2.8.0

* Updated changelog for version 2.8

* Update README

* Update README

* Add the feature search functionality

* Forgot file in previous commit

* Improve map thumbnails

* Make layer configuration in json map more robust

* Removed a stale file

* Adds a status message when updating the gazetteer fields for a layer

* Fixes #334

* Fixes #300

* Fixes #330

* Fixes #327

* Fixes #336

* Fixes #340

* Align to master branch

* Fixes #343

* Prepare 2.8.1

*  - Fix issue with layer upload

*  - Fix issue with layer upload

* Backport master fixes

*  - Fix reproj issue on bbox_to_projection

* fix slow login/logout on certain circumstances

It seems connexion was make through public location,
while it's an internal call, making the request
very slow on some setups (not sure geoserver login
works anyway...)

* use geoip2 for monitoring

* Use HTML widget in GXP for any field starting with "descriptio". Refs #348

* Constrain pip to 9.0.3

* Updated changelog for version 2.8

* Backporting Master PRs

* Fixes #350

* Re-enable thumbnails for layers. Fixes #351

* Now categories order is respected for existing maps. Refs #341

* Sync with GeoNode 2.8 part 1/2

* Updating geoexplorer to last version

* Fixes a couple of things which were broken by merge with 2.8.0

* Fixing a couple of things broke when merging

* renaming celery to celery_app

* Fixes the updatelayers command

* Update helpers.py

* Backporting Master PRs

* Backporting Master PRs

* Fixes #367

* Fixes 31

Adding the {% trans %} tag for translation.

* Fixes https://github.com/camp-zju/geonode/issues/32

Add lable _() for translation

* Fixes https://github.com/camp-zju/geonode/issues/33

Add "Text" in .js file for translation

* Fixes https://github.com/camp-zju/geonode/issues/34

add Tianditu basemap

* Add Chinese translation file

* Add Chinese translation file

* Fixes https://github.com/camp-zju/geonode/issues/36

* Modify the file for translation

* Fixes https://github.com/camp-zju/geonode/issues/37

* Some improvement to the createlayer application

* Fixes part of #358 (the layer extent)

* Now thumbanils are not generate from layers which are created. Fixes #358

* Backporting Master PRs

* Fixes #3801

* Fixes #375

* Backporting Master PRs

* Update integration.py

*  - Backport fixes from master

*  - Backport fixes from master

*  - Allow registered users to edit Remote Services

* Updating the client

* Move the worldmap documentation to the correct place

* Removed stale worldmap documentation page

*  - Backport commit 15123a5 from master

* A couple of fixes and removing geoexplorer source code

*  - Backport commit 6c0e8ca from master

* Removing from git the compiled geoexplorer worldmap client

* Removing worldmap account, which will be part of the cga geonode project

* Removing all static files, which should be added by pip install worldmap-geoexplorer

* Fixing a number of things before sending PR to GeoNode 2.7.x

* Updated requirements for WorldMap

* Including a local_settings sample file for worldmap

* Now using django-geoexplorer-worldmap from the pypi package

*  - Backport fixes from master branch

* Updated worldmap installation documentation

* Removed the worldmap.queue application for now

* Reset a couple of files

*  - Backport from master

* Fixes pep8 violations

* By default USE_WORLDMAP is False

* Fixes PEP8 violations and a syntax error

* Fixes a problem with createlayer app

* By default we dont use hypermap

* [Backport fixes from master]

* [Backport fixes from master]

* Backport from master branch

*  - SITEURL rstrip (/) consistently

* [Fixes #3800] Uploading shapefiles without a datefield and time-enabled is False in importer settings fails in 2.7.x

*  - Backport stable fixes from master branch

*  - Backport stable fixes from master branch

*  - Backporting Docker Improvs and Fixes from master branch

* Update Dockerfile

* Externalize OGC TIMEOUT setting as ENV var

*  - Fix celery initialization when using GeoNode ad a depenency

* pep8 issues

* - Fix celery initialization when using GeoNode ad a depenency

* - Fix celery initialization when using GeoNode ad a depenency

* - Fix celery initialization when using GeoNode ad a depenency

* pep8 fixes

* - Fix celery initialization when using GeoNode ad a depenency

*  - Fixes layer replace

* Update helpers.py

* Update helpers.py

* add missing ast import

docker compose would fail due to a missing import, looking for global ast

* [backport 2.7.x] Minor improvements: allow registered users to invite others / improve French translation

*  - Packagin scripts updates

*  - Fix max zoom issue

*  - backport from master

*  - Backport fixes and PRs from master

*  - Minor Layout improvements

*  - Backport fixes and PRs from master (#3846)

*  - Backport fixes and PRs from master

*  - Minor Layout improvements

* Backport fixes from master branch

* Backport fix #3853

* Backport #3856

*  - Backporting master branch fixes

*  - Backporting fixes from master

* Backport fixes from master

* Backport fixes from master

*  - Fix integration tests

* Backport fixes from master

*  - Fix typo

* Ported the mobile client as per #404

* Includes commands in Makefile to create and remove databases needed when using the worldmap contrib application

* Now there is not a local_settings.py file, so we need to set DATABASES when using worldmap application

* Updated worldmap installation instructions and setup_worlmap make command

* When parsing ALLOWED_HOSTS the error can be more generic (in my case got a syntax error)

* Added the initial migration for datastore_shards app

* Fix issue with styles introduced with latest GeoNode synced code

* Correctly reference the google maps api

* add some localizations

* Skip a layer in the map if its source is missing

* Add localization

* Uncommenting a line wrongly commented out

* Started the GeoFence refactoring

* Fixes a problem with owner permissions not being synced on geofence

* Use psycopg2 for syncing geofence if there is a GEOFENCE_URL setting

* Handle a case of possible null values from geofence database

* Adding a GEOFENCE_URL in OGC_SERVER

* Fixes permissions sync with geofence for anonymous users

* Fixes an issue with guardian anonymous permissions

* Fixes another issue with anonymous user

* Skipping not anymore existing layers in maps

* Fixes the google maps api path

* Fixes #441

* Fixes #439

* Make sure coordinates are not flipped for a wm map

* Removing an unwanted print statment

* Fixes #454

* Fixes after sync with master

* Fixes pep8 violations

* Fixes some problem with automatic merge and migrations
marthamareal pushed a commit to marthamareal/geonode that referenced this issue Sep 24, 2021
@luorlandini
Client - Change the "Save As" button inside the save as window to "Sa…
8d1d946 
…ve" (GeoNode#273)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jj0hns0n jj0hns0n

Labels
gnip A GeoNodeImprovementProcess Issue
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
5 participants
@rmarianski @sbenthall @jj0hns0n @simod @tomkralidis