Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faceting: improvement: key to filter #11226

Closed
etj opened this issue Jul 5, 2023 · 2 comments
Closed

Faceting: improvement: key to filter #11226

etj opened this issue Jul 5, 2023 · 2 comments
Assignees
Labels
Milestone

Comments

@etj
Copy link
Contributor

etj commented Jul 5, 2023

Rename facet entry key to filter.

Rationale

As described in #10995, payload is

  • facet is a dict:
    key type opt description
    name str no Name of the facet (to be used in the /facet/<facet_name> entrypoint)
    key str no string to be used as KVP param in the resources query
    label str no Label for the facet (could be localized)
    ...

Since key is also used elsewhere in the payload, it would be better to have different names for different purposes, so the facet info key should be renamed to filter.

The client using this info should be changed as well, so we'll probably need 2 commits:

  1. add the new filter enty
  2. wait a bit the client to be aligned with the new name
  3. create a new commit that removes the old key entry.
@etj etj added the master label Jul 5, 2023
@etj etj added this to the 4.2.0 milestone Jul 5, 2023
@etj etj self-assigned this Jul 5, 2023
@etj
Copy link
Contributor Author

etj commented Jul 7, 2023

@allyoucanmap please advise when this change is reflected on the client side

@etj
Copy link
Contributor Author

etj commented Jul 28, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant