Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes #942] Failing datasets uploads are generating double entries in the list of not processed upload #952

Merged
merged 2 commits into from
May 10, 2022
Merged

[Fixes #942] Failing datasets uploads are generating double entries in the list of not processed upload #952

merged 2 commits into from
May 10, 2022

Conversation

DavidQuartz
Copy link
Member

@DavidQuartz DavidQuartz commented Apr 21, 2022 •
edited by giohappy
Loading

ref #942

This PR fixes the double error entries and introduces an error tooltip inside <PendingUploadCard>
Screenshot 2022-04-21 at 15 58 43

@DavidQuartz DavidQuartz added bug Something isn't working 4.0.x labels Apr 21, 2022
@DavidQuartz DavidQuartz added this to the 4.0.0 milestone Apr 21, 2022
@DavidQuartz DavidQuartz self-assigned this Apr 21, 2022
@giohappy giohappy merged commit c74d130 into GeoNode:master May 10, 2022
@giohappy giohappy changed the title Failing datasets uploads are generating double entries in the list of not processed upload [Fixes #924] Failing datasets uploads are generating double entries in the list of not processed upload May 10, 2022
@giohappy giohappy changed the title [Fixes #924] Failing datasets uploads are generating double entries in the list of not processed upload ref #924 Failing datasets uploads are generating double entries in the list of not processed upload May 10, 2022
@giohappy giohappy changed the title ref #924 Failing datasets uploads are generating double entries in the list of not processed upload [Fixes #924] Failing datasets uploads are generating double entries in the list of not processed upload May 10, 2022
@giohappy giohappy changed the title [Fixes #924] Failing datasets uploads are generating double entries in the list of not processed upload [Fixes #942] Failing datasets uploads are generating double entries in the list of not processed upload May 10, 2022
@DavidQuartz
Copy link
Member Author

@marthamareal can you please test on master?

@marthamareal
Copy link

@giohappy, @DavidQuartz, was this deployed to master.demo?,
A trying to test but i still see unprocessed uploads being listed.

Here are the steps am taking.

  1. On the dataset upload page.
  2. Select files to upload
  3. Inspect and set the network to offline
  4. Click Upload.
    The request is not made but the dataset is listed in uploads with fail status.(See image below)
    ss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allyoucanmap allyoucanmap allyoucanmap approved these changes

Assignees

@DavidQuartz DavidQuartz

Labels
4.0.x BackportNeeded bug Something isn't working
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidQuartz @marthamareal @allyoucanmap @giohappy