Skip to content

Commit

Permalink
[Fixes 1174] Error not correctly shown error (#1176)
Browse files Browse the repository at this point in the history
* [Fixes 1174]

* making error log more human readable
  • Loading branch information
DavidQuartz committed Sep 8, 2022
1 parent cf68620 commit cfdfd3a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ function UploadCard({
: null}
{(state === 'INVALID' || status === 'failed')
? <>
{!errorLog ? <ErrorMessageWithTooltip tooltipId={<Message msgId={`gnviewer.${getUploadErrorMessageFromCode(error?.code)}`} msgParams={{ limit: getUploadErrorMessageFromCode(error?.code) === 'fileExceeds' ? maxAllowedSize : maxParallelUploads }} />} />
: <ErrorMessageWithTooltip tooltip={getUploadErrorMessageFromCode(null, errorLog)} />
{!errorLog ? <ErrorMessageWithTooltip tooltipPosition="left" tooltipId={<Message msgId={`gnviewer.${getUploadErrorMessageFromCode(error?.code)}`} msgParams={{ limit: getUploadErrorMessageFromCode(error?.code) === 'fileExceeds' ? maxAllowedSize : maxParallelUploads }} />} />
: <ErrorMessageWithTooltip tooltipPosition="left" tooltip={getUploadErrorMessageFromCode(null, errorLog)} />
}
</>
: null}
Expand Down
4 changes: 3 additions & 1 deletion geonode_mapstore_client/client/js/utils/ErrorUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@

export const getUploadErrorMessageFromCode = (code, log) => {
if (log) {
return log;
// Make the error log more human readable
const errorMsg = log.replace(/[()]/g, '')?.replace(/[\[\]']+/g, '')?.split('ErrorDetailstring=')?.join(' ');
return errorMsg;
}
switch (code) {
case 'upload_parallelism_limit_exceeded': {
Expand Down

0 comments on commit cfdfd3a

Please sign in to comment.