Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate vue plugin to 5 #510

Merged
merged 2 commits into from
Jul 31, 2022
Merged

chore: migrate vue plugin to 5 #510

merged 2 commits into from
Jul 31, 2022

Conversation

BilelJegham
Copy link
Member

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #510 (92b7803) into master (8aa2b6e) will decrease coverage by 4.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
- Coverage   55.81%   51.34%   -4.47%     
==========================================
  Files          46       52       +6     
  Lines         774      742      -32     
  Branches      158      205      +47     
==========================================
- Hits          432      381      -51     
- Misses        310      329      +19     
  Partials       32       32              
Impacted Files Coverage Δ
src/components/shared/TimePicker.vue 100.00% <ø> (ø)
src/mixins/ConfirmExitMixin.js 23.52% <0.00%> (-3.14%) ⬇️
src/plugins/StreetViewService.js 48.91% <0.00%> (-2.86%) ⬇️
src/components/map/mixins/MapMixin.js 25.00% <0.00%> (-2.28%) ⬇️
src/utils/index.js 72.47% <0.00%> (-0.60%) ⬇️
src/store/modules/home.store.js 64.51% <0.00%> (-0.53%) ⬇️
src/store/modules/settings.store.js 23.87% <0.00%> (-0.30%) ⬇️
src/plugins/IndexedDBService.js 7.93% <0.00%> (-0.13%) ⬇️
src/pages/Home.vue 100.00% <0.00%> (ø)
src/components/Maps.vue 100.00% <0.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa2b6e...92b7803. Read the comment docs.

@BilelJegham BilelJegham merged commit 95582ec into master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant