Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Save PlayerName #186

Closed
BilelJegham opened this issue Jun 4, 2021 · 2 comments · Fixed by #256
Closed

[FEAT] Save PlayerName #186

BilelJegham opened this issue Jun 4, 2021 · 2 comments · Fixed by #256
Assignees
@BilelJegham
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BilelJegham
Copy link
Member

Is your feature request related to a problem? Please describe.
Save playername in the waiting room
image
@BilelJegham BilelJegham added enhancement New feature or request good first issue Good for newcomers labels Jun 4, 2021
@BurAndBY
Copy link

I have idea of adding registration. #192

@BilelJegham BilelJegham mentioned this issue Jun 17, 2021
Closed
@BilelJegham
Copy link
Member Author

More simple, save the playername in the localStorage

@BurAndBY BurAndBY mentioned this issue Sep 15, 2021
Closed
BilelJegham added a commit that referenced this issue Sep 25, 2021
@BilelJegham
feat: #186 Save Player Name
9b3e791
@BilelJegham BilelJegham mentioned this issue Sep 25, 2021
Merged
@BilelJegham BilelJegham self-assigned this Sep 25, 2021
BilelJegham added a commit that referenced this issue Sep 26, 2021
@BilelJegham
feat: #186 Save Player Name (#256)
a879510 
* feat: #186 Save Player Name

* add tests: settingsStore

* fix: lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BilelJegham BilelJegham

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #186 Save Player Name GeoGuess/GeoGuess
2 participants
@BilelJegham @BurAndBY