Include list header to appease g++-12 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing an upgrade of package
BHagainst all its reverse-dependencies (see this issue for details) I noticed thatrgeodafailed to build.The cause is unrelated to the
BHupgrade and due to the fact that I ran the tests with g++-12 (on Debian testing). The newer compiler wants an explicit#includefor thestd::listdata structure. Once that one line is added the package installs and tests fine underg++-12.I followed the git source via the submodule to this repo. The change is very simple. It would be lovely if you could update the package at CRAN even though this is more of a g++ issue than a BH issue (but 'eventually' CRAN will nag on this too). I see that CRAN also nags on the
sprintfissue per this log which should be easy to fix at the same time.