-
-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new option --encoder-name #1827
Conversation
@rom1v did you get a chance to take a look? |
Sorry, not yet in details. Currently, I have no time to work on scrcpy (I just answer to issues if I can give a quick answer). But I have it in mind (and in my todo list), and this option will be merged before a new release. 👍 One additional thing I would like to add is listing the available encoder names on error (like the |
I rebased on current Please review and test: If it's ok, I'll merge into |
Looks good to me! |
Merged into |
Here are binaries for the current For windows users, take both For other platforms, take
(to replace in v1.16 release) scrcpy --encoder _ # will list the available encoders in the error message
scrcpy --encoder SOME_ENCODER |
scrcpy v1.17 Changes since v1.16: - Fix errors on Android 11 (Genymobile#1468) - Add --encoder option (Genymobile#1810, Genymobile#1827) - Add --forward-all-clicks option (Genymobile#1302, Genymobile#1613) - Add --legacy-paste option (Genymobile#1750, Genymobile#1771) - Workaround screen off/on issue on exit (Genymobile#1670) - Rework console/noconsole versions on Windows (Genymobile#1875, Genymobile#1988) - Terminate server properly without killing it on close (Genymobile#1992) - List available shortcut keys on error (Genymobile#1681) - Upgrade platform-tools to 30.0.5 (adb) in Windows releases - Upgrade SDL to 2.0.14 in Windows releases
Relates to issue #1810
It seems that some devices have more than one encoder, some encoders may cause issues or crash.
With this option we can specify which encoder we want the device to use.
Proved useful for the device in the issue.