-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check files for UNIX-style line breaks and 644 permission #736
Conversation
82335b7
to
ef9f647
Compare
Running `dos2unix` and check if there are any changes to make sure that we don't include any files with DOS-style line breaks.
ef9f647
to
a711a67
Compare
/format |
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
I'll leave it up to you if you decide to implement the permissions (x, 755) check here or in a separate PR as discussed at #734 (comment). Also, we should probably have a policy statement in CONTRIBUTING.md on the use of UNIX style line-endings and correct permissions (644) of files. |
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
I just added one sentence to address the policy. |
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Description of proposed changes
Running
dos2unix
to all Python scripts and check if there are any files changed,to make sure that we don't include any files with DOS-style line breaks.
The style checks fail due to #734. It also means that the line-break style check works as expected.
However, I can't use
/format
to automatically fix the line-break issue, as theslash command dispatch read the workflow in the master branch only.
Address #734.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Notes
/format
in the first line of a comment to lint the code automatically