clib.Session: Remove deprecated virtualfile_from_data method, use virtualfile_in instead (Deprecated since v0.13.0) #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recated since v0.13.0)
seisman
added
deprecation
seisman
commented
Jan 2, 2025
| @@ -128,35 +128,3 @@ def test_virtualfile_in_matrix_string_dtype(): | |||
| assert output == "347.5 348.5 -30.5 -30\n" | |||
| # Should check that lib.virtualfile_from_vectors is called once, | |||
| # not lib.virtualfile_from_matrix, but it's technically complicated. | |||
|
|
|||
|
|
|||
| # TODO(PyGMT>=0.16.0): Remove this test in PyGMT v0.16.0 in which the old usage of | |||
There was a problem hiding this comment.
There was a typo in #3722. This test should be removed in PyGMT v0.15.0, not PyGMT v0.16.0.
michaelgrund
approved these changes
Jan 2, 2025
michaelgrund
added
final review call
yvonnefroehlich
approved these changes
Jan 2, 2025
weiji14
changed the title
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session.virtualfile_from_datawas deprecated in #3225.