Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote datasets: Add "load_earth_mean_sea_surface" to load "CNES Earth Mean Sea Surface" dataset #3717

Merged
merged 11 commits into from
Dec 26, 2024

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Dec 25, 2024

Description of proposed changes

Add load_earth_mean_sea_surface to download the "CNES Earth Mean Sea Surface" dataset and load into a xarray.DataArray:

Adresses #2431

Preview: https://pygmt-dev--3717.org.readthedocs.build/en/3717/api/generated/pygmt.datasets.load_earth_mean_sea_surface.html

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added the enhancement Improving an existing feature label Dec 25, 2024
@yvonnefroehlich yvonnefroehlich self-assigned this Dec 25, 2024
@yvonnefroehlich yvonnefroehlich marked this pull request as draft December 25, 2024 12:13
@seisman seisman added feature Brand new feature and removed enhancement Improving an existing feature labels Dec 26, 2024
@seisman seisman added this to the 0.14.0 milestone Dec 26, 2024
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@yvonnefroehlich yvonnefroehlich marked this pull request as ready for review December 26, 2024 08:39
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 26, 2024
@yvonnefroehlich yvonnefroehlich changed the title WIP: Remote datasets: Add "load_earth_mean_sea_surface" to load "CNES Earth Mean Sea Surface" dataset Remote datasets: Add "load_earth_mean_sea_surface" to load "CNES Earth Mean Sea Surface" dataset Dec 26, 2024
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 26, 2024
@seisman seisman merged commit 16919ad into main Dec 26, 2024
22 checks passed
@seisman seisman deleted the add-remote-earth-mss branch December 26, 2024 11:43
@yvonnefroehlich yvonnefroehlich mentioned this pull request Dec 26, 2024
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants