-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Convert README from ReST to Markdown #3059
Conversation
|
…ert-readme-rst2md
Thanks for posting this list! These files should be updated in the commits 3360f45, 7be24c3, and a68367c. |
Currently building the documentation fails and the issue seem to be related to downloading the GMT remote datasets:
Is there currently any maintenance regarding the remote datasets and they are temporarily not available? |
Do other mirrors work? |
now it's working again. the service was probably under maintenance. |
It looks like downloading the remote datasets works again and this was only a temporary issue. |
Does the solution here |
doc/index.rst
Outdated
.. include:: ../README.md | ||
:start-after: doc-index-start-after | ||
:end-before: doc-index-end-before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. include:: ../README.md | |
:start-after: doc-index-start-after | |
:end-before: doc-index-end-before | |
```{include} ../README.md | |
:start-after: doc-index-start-after | |
:end-before: doc-index-end-before | |
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps you have to convert index.rst to index.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try this, but I will be quite busy in the next three weeks. Thus, I am not sure if I will have the time to do this in the next days 🙁.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done this in commit 514420a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @seisman for doing this and completing this PR.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
doc/maintenance.md
Outdated
### Check the README Syntax | ||
|
||
GitHub is a bit forgiving when it comes to the RST syntax in the README but PyPI is not. | ||
GitHub is a bit forgiving when it comes to the syntax in the README but PyPI is not. | ||
To check the README syntax, visit the | ||
[PyGMT TestPyPI release history](https://test.pypi.org/project/pygmt/#history), select | ||
the latest commit, and review the left sidebar and project description for any errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://packaging.python.org/en/latest/guides/making-a-pypi-friendly-readme/#creating-a-readme-file
PyPI uses the GitHub Flavored Markdown syntax by default, so we no longer need to check the README syntax on PyPI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 1342678.
Description of proposed changes
This PR converts the REAMDE from ReStructuredText to Markdown.
pandoc
to convert to markdownAdding
.. doc-index-start-after
and.. doc-index-end-before
does not work correctly. We have to look for the corresponding Markdown syntaxPreview:
Fixes #2928
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash command is:
/format
: automatically format and lint the code