-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Cache gmt_hash_server.txt and gmt_data_server.txt files #3020
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7d03f43
CI: Cache gmt_hash_server.txt and gmt_data_server.txt files
seisman 972b1ab
Update the touch commands in other workflows
seisman 49178fc
Fix the file path in the GMT Legacy Tests workflow
seisman e7f8277
Temporarily enable the GMT Legacy Tests workflow in PR
seisman a809b32
Revert "Temporarily enable the GMT Legacy Tests workflow in PR"
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these files supposed to be downloaded automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally yes, but old GMT versions may fail to download these files on GitHub Actions (see https://github.com/GenericMappingTools/pygmt/actions/runs/7619206138/job/20751859452):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah got it, so this is needed for the GMT legacy tests (using GMT 6.3.0 and 6.4.0). I see that the path has changed from
~/.gmt/server/gmt_data_server.txt
to~/.gmt/gmt_data_server.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to copy
~/.gmt/gmt_data_server.txt
to~/.gmt/server/gmt_data_server.txt
though for the GMT Legacy tests?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My local tests tell me that we have to. Will do it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 49178fc and the same error is gone in the GMT Legacy Tests workflow (https://github.com/GenericMappingTools/pygmt/actions/runs/7677658040/job/20926661680?pr=3020).